-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fixed when using the decimal number in slidesToShow. #845
base: develop
Are you sure you want to change the base?
Conversation
@magento run all tests |
@magento run Functional Tests B2B |
@magento run all tests |
@magento run Functional Tests B2B, Integration Tests, Performance Acceptance Tests, Static Tests, Unit Tests |
@magento run Functional Tests B2B |
✔️ QA Passed Preconditions: Implement Slick slider with Magento and enable PageBuilder Manual testing scenario:
Actual Result: ✔️ After: ✔️ Before: ✖️ The Failed B2B test is flaky, past 2 consecutive runs, the build failures are different: Hence moving to Thanks |
Description (*)
Slick slider unofficially enables the use of decimal point in the slidesToShow attribute. When we define the 5.2 to the slidesToShow attribute, slick slider will show the 5 items and the 20 percent of 6 item. But we need to use undecimal number in the slidesToScroll parameter. Otherwise, the slider will miscalculate. This pull request aims to solve this problem.
Manual testing scenarios (*)
Checklist