Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PWA-1884] Containers (Column, ColumnGroup, Row, Tabs) Components - Base Styles #3876

Draft
wants to merge 1 commit into
base: PWA-1895
Choose a base branch
from

Conversation

anthoula
Copy link
Contributor

@anthoula anthoula commented Jun 6, 2022

Description

As a frontend developer I want theme configuration to affect the styles of components that are used to render content created with pagebuilder so that* page builder content styled consistently with the rest of the storefront

Acceptance Criteria

  • pageBuilder components css is informed by the base theme defined in the tailwind configuration
  • content created in page builder looks aligned with base styles
  • Business user goes to the Admin Panel, opens page created with page builder, changes the global styles of the content types (H1-H5, text, buttons, etc) saves the changes and sees those styles updated based on the Monarch theme config
  • page builder components work as expected

Related Issue

  • PWA-1884 Containers (Column, ColumnGroup, Row, Tabs) Components - Base Styles

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

  • Verify the pages on Venia where pagebuilder Column, ColumnGroup, Row, Tabs components used like Home page, Customer Service, About Us pages.
  • Add new CMS page with Pagebuilder with Column, ColumnGroup, Row, Tabs type components and verify it loads properly.
  • Run Cypress all tests and make sure everything works.
  • Run yarn watch, bundle size, build:Report cli commands still work.
  • Create scaffolding and verify all supported cli commands still work.
  • Quickly verify Venia UI in Firefox, Safari , Android chrome and iOS safari.
  • Verify lighthouse and webpage test scores.
  • Verify when Admin updates pagebuilder styles then venia page should be updated with respect to Monarch theme configs.
  • Verify tab order on pagebuilder product components and try select and deselect using keyboard.

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

…se Styles

- update row, tab items, and tailwind present to base theme
@pwa-studio-bot
Copy link
Collaborator

Fails
🚫 A version label is required. A maintainer must add one.
Messages
📖

Associated JIRA tickets: PWA-1884.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 20eae4d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants