Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed pagebuilder tab toggle issue #4327

Closed

Conversation

del22123
Copy link
Collaborator

Description

This PR contains the fix for CSS issues in page builder tab content toggle.

Closes #PWA-3356
https://jira.corp.adobe.com/browse/PWA-3356

Acceptance

Verification Stakeholders

Specification

Verification Steps

Step 1: Create a static content (Either a page or static block) in Magento admin panel
Step 2: Use page builder to edit the content, drag and drop "Tab" inside a row
(Drag and drop the "Row" into the content area if it's not there already)
Step 3: Create multiple tabs to have toggle in storefront
Step 4: Save the content and check the tab(s) in storefront
(Configure the static block/page appropriately so that the content will be visible in storefront)

Current result:
Empty space will be visible on each tab switch

Fix result:
The tab content toggle will work and there won't be any empty space/in-active tab content displayed.

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@pwa-studio-bot
Copy link
Collaborator

Fails
🚫 A version label is required. A maintainer must add one.
Messages
📖

Associated JIRA tickets: PWA-3356.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 47ce6b3

@del22123 del22123 added the version: Patch This changeset includes backwards compatible bug fixes. label Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:pagebuilder version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants