Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

main synch with release 14.1.0 change.log md #4338

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

glo42707
Copy link
Contributor

@glo42707 glo42707 commented Sep 30, 2024

Description

synch PR for main from 14.1.0 release branch name -->>> synch-release14.1.0

Related Issue

Closes #PWA-3349

Acceptance

Verification Stakeholders

Specification

Verification Steps

Test scenario(s) for direct fix/feature

Test scenario(s) for any existing impacted features/areas

Test scenario(s) for any Magento Backend Supported Configurations

Is Browser/Device testing needed?

Any ad-hoc/edge case scenarios that need to be considered?

Screenshots / Screen Captures (if appropriate)

Breaking Changes (if any)

Checklist

  • I have added tests to cover my changes, if necessary.
  • I have added translations for new strings, if necessary.
  • I have updated the documentation accordingly, if necessary.

@glo42707 glo42707 changed the title adding release 14.1.0 change.log md main synch with release 14.1.0 change.log md Sep 30, 2024
@glo42707 glo42707 added the version: Patch This changeset includes backwards compatible bug fixes. label Sep 30, 2024
@glo42707 glo42707 self-assigned this Sep 30, 2024
@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Sep 30, 2024

Fails
🚫

Whoops! Pull requests should be opened against develop, not main. Please reopen this PR against the correct branch.

Messages
📖

Associated JIRA tickets: PWA-3349.

📖 DangerCI Failures related to missing labels/description/linked issues/etc will persist until the next push or next pr-test build run (assuming they are fixed).
📖

Access a deployed version of this PR here. Make sure to wait for the "pwa-pull-request-deploy" job to complete.

Generated by 🚫 dangerJS against 30877b4

@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Sep 30, 2024

Fails
🚫

node failed.

🚫

Cypress tests in the following files did not pass 😔. All tests must pass before this PR can be merged

  • Verify content:
    • Error: Image size (1280x1869) different than saved snapshot size (1280x1463). See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/aboutUsPage/aboutUsPage.spec.js/__diff_output__/AboutUs.diff.png
  • Verify content:
    • Error: Image size (1280x2069) different than saved snapshot size (1280x1846). See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/customerService/customerService.spec.js/__diff_output__/Customer-Service-Page.diff.png
  • verify buttons content:
    • Error: Image size (1280x8562) different than saved snapshot size (1280x7846). See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/buttons.spec.js/__diff_output__/Page-Builder-Buttons-Page.diff.png
  • verify column content:
    • CypressError: `cy.visit()` failed trying to load:

      https://pr-4338.pwa-venia.com/

      We attempted to make an http request to this URL but the request failed without a response.

      We received this error at the network level:

      Error: getaddrinfo ENOTFOUND pr-4338.pwa-venia.com

      Common situations why this would fail:

      • you don't have internet access
      • you forgot to run / boot your web server
      • your web server isn't accessible
      • you have weird network configuration settings on your computer
      ,should apply mediaQuery styles:
      • CypressError: cy.visit() failed trying to load:

      https://pr-4338.pwa-venia.com/

      We attempted to make an http request to this URL but the request failed without a response.

      We received this error at the network level:

      Error: getaddrinfo ENOTFOUND pr-4338.pwa-venia.com

      Common situations why this would fail:

      • you don't have internet access
      • you forgot to run / boot your web server
      • your web server isn't accessible
      • you have weird network configuration settings on your computer
    • verify google map api load with content:
      • CypressError: cy.visit() failed trying to load:

      https://pr-4338.pwa-venia.com/

      We attempted to make an http request to this URL but the request failed without a response.

      We received this error at the network level:

      Error: getaddrinfo ENOTFOUND pr-4338.pwa-venia.com

      Common situations why this would fail:

      • you don't have internet access
      • you forgot to run / boot your web server
      • your web server isn't accessible
      • you have weird network configuration settings on your computer

      verify mocked google map api with two markers and click event:
      • CypressError: cy.visit() failed trying to load:

      https://pr-4338.pwa-venia.com/

      We attempted to make an http request to this URL but the request failed without a response.

      We received this error at the network level:

      Error: getaddrinfo ENOTFOUND pr-4338.pwa-venia.com

      Common situations why this would fail:

      • you don't have internet access
      • you forgot to run / boot your web server
      • your web server isn't accessible
      • you have weird network configuration settings on your computer
    • verify divider content:
      • CypressError: cy.visit() failed trying to load:

      https://pr-4338.pwa-venia.com/

      We attempted to make an http request to this URL but the request failed without a response.

      We received this error at the network level:

      Error: getaddrinfo ENOTFOUND pr-4338.pwa-venia.com

      Common situations why this would fail:

      • you don't have internet access
      • you forgot to run / boot your web server
      • your web server isn't accessible
      • you have weird network configuration settings on your computer
    • verify dynamic block content:
      • CypressError: cy.visit() failed trying to load:

      https://pr-4338.pwa-venia.com/

      We attempted to make an http request to this URL but the request failed without a response.

      We received this error at the network level:

      Error: getaddrinfo ENOTFOUND pr-4338.pwa-venia.com

      Common situations why this would fail:

      • you don't have internet access
      • you forgot to run / boot your web server
      • your web server isn't accessible
      • you have weird network configuration settings on your computer
    • verify banner content:
      • Error: Image size (1280x2004) different than saved snapshot size (1280x1882).
        See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/banner.spec.js/diff_output/Page-Builder-Home-Page.diff.png

      verify banner content2:
      • CypressError: cy.visit() failed trying to load:

      https://pr-4338.pwa-venia.com/

      We attempted to make an http request to this URL but the request failed without a response.

      We received this error at the network level:

      Error: getaddrinfo ENOTFOUND pr-4338.pwa-venia.com

      Common situations why this would fail:

      • you don't have internet access
      • you forgot to run / boot your web server
      • your web server isn't accessible
      • you have weird network configuration settings on your computer

      verify banner content3:
      • CypressError: cy.visit() failed trying to load:

      https://pr-4338.pwa-venia.com/

      We attempted to make an http request to this URL but the request failed without a response.

      We received this error at the network level:

      Error: getaddrinfo ENOTFOUND pr-4338.pwa-venia.com

      Common situations why this would fail:

      • you don't have internet access
      • you forgot to run / boot your web server
      • your web server isn't accessible
      • you have weird network configuration settings on your computer

      verify banner content4:
      • CypressError: cy.visit() failed trying to load:

      https://pr-4338.pwa-venia.com/

      We attempted to make an http request to this URL but the request failed without a response.

      We received this error at the network level:

      Error: getaddrinfo ENOTFOUND pr-4338.pwa-venia.com

      Common situations why this would fail:

      • you don't have internet access
      • you forgot to run / boot your web server
      • your web server isn't accessible
      • you have weird network configuration settings on your computer

      verify banner content5:
      • CypressError: cy.visit() failed trying to load:

      https://pr-4338.pwa-venia.com/

      We attempted to make an http request to this URL but the request failed without a response.

      We received this error at the network level:

      Error: getaddrinfo ENOTFOUND pr-4338.pwa-venia.com

      Common situations why this would fail:

      • you don't have internet access
      • you forgot to run / boot your web server
      • your web server isn't accessible
      • you have weird network configuration settings on your computer

      verify banner content6:
      • CypressError: cy.visit() failed trying to load:

      https://pr-4338.pwa-venia.com/

      We attempted to make an http request to this URL but the request failed without a response.

      We received this error at the network level:

      Error: getaddrinfo ENOTFOUND pr-4338.pwa-venia.com

      Common situations why this would fail:

      • you don't have internet access
      • you forgot to run / boot your web server
      • your web server isn't accessible
      • you have weird network configuration settings on your computer

      verify banner content7:
      • CypressError: cy.visit() failed trying to load:

      https://pr-4338.pwa-venia.com/

      We attempted to make an http request to this URL but the request failed without a response.

      We received this error at the network level:

      Error: getaddrinfo ENOTFOUND pr-4338.pwa-venia.com

      Common situations why this would fail:

      • you don't have internet access
      • you forgot to run / boot your web server
      • your web server isn't accessible
      • you have weird network configuration settings on your computer

      verify banner content8:
      • CypressError: cy.visit() failed trying to load:

      https://pr-4338.pwa-venia.com/

      We attempted to make an http request to this URL but the request failed without a response.

      We received this error at the network level:

      Error: getaddrinfo ENOTFOUND pr-4338.pwa-venia.com

      Common situations why this would fail:

      • you don't have internet access
      • you forgot to run / boot your web server
      • your web server isn't accessible
      • you have weird network configuration settings on your computer

      verify banner content9:
      • CypressError: cy.visit() failed trying to load:

      https://pr-4338.pwa-venia.com/

      We attempted to make an http request to this URL but the request failed without a response.

      We received this error at the network level:

      Error: getaddrinfo ENOTFOUND pr-4338.pwa-venia.com

      Common situations why this would fail:

      • you don't have internet access
      • you forgot to run / boot your web server
      • your web server isn't accessible
      • you have weird network configuration settings on your computer

      verify banner content10:
      • CypressError: cy.visit() failed trying to load:

      https://pr-4338.pwa-venia.com/

      We attempted to make an http request to this URL but the request failed without a response.

      We received this error at the network level:

      Error: getaddrinfo ENOTFOUND pr-4338.pwa-venia.com

      Common situations why this would fail:

      • you don't have internet access
      • you forgot to run / boot your web server
      • your web server isn't accessible
      • you have weird network configuration settings on your computer
      ,should apply mediaQuery styles:
      • CypressError: cy.visit() failed trying to load:

      https://pr-4338.pwa-venia.com/

      We attempted to make an http request to this URL but the request failed without a response.

      We received this error at the network level:

      Error: getaddrinfo ENOTFOUND pr-4338.pwa-venia.com

      Common situations why this would fail:

      • you don't have internet access
      • you forgot to run / boot your web server
      • your web server isn't accessible
      • you have weird network configuration settings on your computer
    • verify slider content:
      • Error: Image size (1280x1564) different than saved snapshot size (1280x1404).
        See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/slider.spec.js/diff_output/Page-Builder-Slider-Page.diff.png

      verify slider content 2:
      • Error: Image size (1280x1564) different than saved snapshot size (1280x1404).
        See diff for details: /venia-integration-tests/src/snapshots/snapshotTests/pageBuilder/slider.spec.js/diff_output/Page-Builder-Slider-Page-2.diff.png

      verify slider content 3:
      • CypressError: Timed out after waiting 30000ms for your remote page to load.

      Your page did not fire its load event within 30000ms.

      You can try increasing the pageLoadTimeout value in /venia-integration-tests/cypress.config.json to wait longer.

      Browsers will not fire the load event until all stylesheets and scripts are done downloading.

      When this load event occurs, Cypress will continue running commands.


    verify slider content 4:
    • CypressError: cy.visit() failed trying to load:

      https://pr-4338.pwa-venia.com/

      We attempted to make an http request to this URL but the request failed without a response.

      We received this error at the network level:

      Error: getaddrinfo ENOTFOUND pr-4338.pwa-venia.com

      Common situations why this would fail:

      • you don't have internet access
      • you forgot to run / boot your web server
      • your web server isn't accessible
      • you have weird network configuration settings on your computer

      verify slider content 5:
      • CypressError: cy.visit() failed trying to load:

      https://pr-4338.pwa-venia.com/

      We attempted to make an http request to this URL but the request failed without a response.

      We received this error at the network level:

      Error: getaddrinfo ENOTFOUND pr-4338.pwa-venia.com

      Common situations why this would fail:

      • you don't have internet access
      • you forgot to run / boot your web server
      • your web server isn't accessible
      • you have weird network configuration settings on your computer

      verify slider content 6:
      • CypressError: cy.visit() failed trying to load:

      https://pr-4338.pwa-venia.com/

      We attempted to make an http request to this URL but the request failed without a response.

      We received this error at the network level:

      Error: getaddrinfo ENOTFOUND pr-4338.pwa-venia.com

      Common situations why this would fail:

      • you don't have internet access
      • you forgot to run / boot your web server
      • your web server isn't accessible
      • you have weird network configuration settings on your computer

      verify slider content 7:
      • CypressError: cy.visit() failed trying to load:

      https://pr-4338.pwa-venia.com/

      We attempted to make an http request to this URL but the request failed without a response.

      We received this error at the network level:

      Error: getaddrinfo ENOTFOUND pr-4338.pwa-venia.com

      Common situations why this would fail:

      • you don't have internet access
      • you forgot to run / boot your web server
      • your web server isn't accessible
      • you have weird network configuration settings on your computer

      verify slider content 8:
      • CypressError: cy.visit() failed trying to load:

      https://pr-4338.pwa-venia.com/

      We attempted to make an http request to this URL but the request failed without a response.

      We received this error at the network level:

      Error: getaddrinfo ENOTFOUND pr-4338.pwa-venia.com

      Common situations why this would fail:

      • you don't have internet access
      • you forgot to run / boot your web server
      • your web server isn't accessible
      • you have weird network configuration settings on your computer

      verify slider content 9:
      • CypressError: cy.visit() failed trying to load:

      https://pr-4338.pwa-venia.com/

      We attempted to make an http request to this URL but the request failed without a response.

      We received this error at the network level:

      Error: getaddrinfo ENOTFOUND pr-4338.pwa-venia.com

      Common situations why this would fail:

      • you don't have internet access
      • you forgot to run / boot your web server
      • your web server isn't accessible
      • you have weird network configuration settings on your computer

      verify slider content 10:
      • CypressError: cy.visit() failed trying to load:

      https://pr-4338.pwa-venia.com/

      We attempted to make an http request to this URL but the request failed without a response.

      We received this error at the network level:

      Error: getaddrinfo ENOTFOUND pr-4338.pwa-venia.com

      Common situations why this would fail:

      • you don't have internet access
      • you forgot to run / boot your web server
      • your web server isn't accessible
      • you have weird network configuration settings on your computer

      verify slider content 11:
      • CypressError: cy.visit() failed trying to load:

      https://pr-4338.pwa-venia.com/

      We attempted to make an http request to this URL but the request failed without a response.

      We received this error at the network level:

      Error: getaddrinfo ENOTFOUND pr-4338.pwa-venia.com

      Common situations why this would fail:

      • you don't have internet access
      • you forgot to run / boot your web server
      • your web server isn't accessible
      • you have weird network configuration settings on your computer

      verify slider content 12:
      • CypressError: cy.visit() failed trying to load:

      https://pr-4338.pwa-venia.com/

      We attempted to make an http request to this URL but the request failed without a response.

      We received this error at the network level:

      Error: getaddrinfo ENOTFOUND pr-4338.pwa-venia.com

      Common situations why this would fail:

      • you don't have internet access
      • you forgot to run / boot your web server
      • your web server isn't accessible
      • you have weird network configuration settings on your computer
      ,should apply mediaQuery styles:
      • CypressError: cy.visit() failed trying to load:

      https://pr-4338.pwa-venia.com/

      We attempted to make an http request to this URL but the request failed without a response.

      We received this error at the network level:

      Error: getaddrinfo ENOTFOUND pr-4338.pwa-venia.com

      Common situations why this would fail:

      • you don't have internet access
      • you forgot to run / boot your web server
      • your web server isn't accessible
      • you have weird network configuration settings on your computer
    • verify smoke test content:
      • CypressError: cy.visit() failed trying to load:

      https://pr-4338.pwa-venia.com/

      We attempted to make an http request to this URL but the request failed without a response.

      We received this error at the network level:

      Error: getaddrinfo ENOTFOUND pr-4338.pwa-venia.com

      Common situations why this would fail:

      • you don't have internet access
      • you forgot to run / boot your web server
      • your web server isn't accessible
      • you have weird network configuration settings on your computer

      verify smoke test cms block content:
      • CypressError: cy.visit() failed trying to load:

      https://pr-4338.pwa-venia.com/

      We attempted to make an http request to this URL but the request failed without a response.

      We received this error at the network level:

      Error: getaddrinfo ENOTFOUND pr-4338.pwa-venia.com

      Common situations why this would fail:

      • you don't have internet access
      • you forgot to run / boot your web server
      • your web server isn't accessible
      • you have weird network configuration settings on your computer

      verify smoke test dynamic block content:
      • CypressError: cy.visit() failed trying to load:

      https://pr-4338.pwa-venia.com/

      We attempted to make an http request to this URL but the request failed without a response.

      We received this error at the network level:

      Error: getaddrinfo ENOTFOUND pr-4338.pwa-venia.com

      Common situations why this would fail:

      • you don't have internet access
      • you forgot to run / boot your web server
      • your web server isn't accessible
      • you have weird network configuration settings on your computer
    • verify block content:
      • CypressError: cy.visit() failed trying to load:

      https://pr-4338.pwa-venia.com/

      We attempted to make an http request to this URL but the request failed without a response.

      We received this error at the network level:

      Error: getaddrinfo ENOTFOUND pr-4338.pwa-venia.com

      Common situations why this would fail:

      • you don't have internet access
      • you forgot to run / boot your web server
      • your web server isn't accessible
      • you have weird network configuration settings on your computer

      verify block dynamic block content:
      • CypressError: cy.visit() failed trying to load:

      https://pr-4338.pwa-venia.com/

      We attempted to make an http request to this URL but the request failed without a response.

      We received this error at the network level:

      Error: getaddrinfo ENOTFOUND pr-4338.pwa-venia.com

      Common situations why this would fail:

      • you don't have internet access
      • you forgot to run / boot your web server
      • your web server isn't accessible
      • you have weird network configuration settings on your computer

      verify block cms block content:
      • CypressError: cy.visit() failed trying to load:

      https://pr-4338.pwa-venia.com/

      We attempted to make an http request to this URL but the request failed without a response.

      We received this error at the network level:

      Error: getaddrinfo ENOTFOUND pr-4338.pwa-venia.com

      Common situations why this would fail:

      • you don't have internet access
      • you forgot to run / boot your web server
      • your web server isn't accessible
      • you have weird network configuration settings on your computer

      verify block cms page content:
      • CypressError: cy.visit() failed trying to load:

      https://pr-4338.pwa-venia.com/

      We attempted to make an http request to this URL but the request failed without a response.

      We received this error at the network level:

      Error: getaddrinfo ENOTFOUND pr-4338.pwa-venia.com

      Common situations why this would fail:

      • you don't have internet access
      • you forgot to run / boot your web server
      • your web server isn't accessible
      • you have weird network configuration settings on your computer
    • verify tabs content:
      • CypressError: cy.visit() failed trying to load:

      https://pr-4338.pwa-venia.com/

      We attempted to make an http request to this URL but the request failed without a response.

      We received this error at the network level:

      Error: getaddrinfo ENOTFOUND pr-4338.pwa-venia.com

      Common situations why this would fail:

      • you don't have internet access
      • you forgot to run / boot your web server
      • your web server isn't accessible
      • you have weird network configuration settings on your computer
      ,should apply mediaQuery styles:
      • CypressError: cy.visit() failed trying to load:

      https://pr-4338.pwa-venia.com/

      We attempted to make an http request to this URL but the request failed without a response.

      We received this error at the network level:

      Error: getaddrinfo ENOTFOUND pr-4338.pwa-venia.com

      Common situations why this would fail:

      • you don't have internet access
      • you forgot to run / boot your web server
      • your web server isn't accessible
      • you have weird network configuration settings on your computer
    • verify text content:
      • CypressError: cy.visit() failed trying to load:

      https://pr-4338.pwa-venia.com/

      We attempted to make an http request to this URL but the request failed without a response.

      We received this error at the network level:

      Error: getaddrinfo ENOTFOUND pr-4338.pwa-venia.com

      Common situations why this would fail:

      • you don't have internet access
      • you forgot to run / boot your web server
      • your web server isn't accessible
      • you have weird network configuration settings on your computer
    • verify video content alignment:
      • CypressError: cy.visit() failed trying to load:

      https://pr-4338.pwa-venia.com/

      We attempted to make an http request to this URL but the request failed without a response.

      We received this error at the network level:

      Error: getaddrinfo ENOTFOUND pr-4338.pwa-venia.com

      Common situations why this would fail:

      • you don't have internet access
      • you forgot to run / boot your web server
      • your web server isn't accessible
      • you have weird network configuration settings on your computer
    • verify row content:
      • CypressError: cy.visit() failed trying to load:

      https://pr-4338.pwa-venia.com/

      We attempted to make an http request to this URL but the request failed without a response.

      We received this error at the network level:

      Error: getaddrinfo ENOTFOUND pr-4338.pwa-venia.com

      Common situations why this would fail:

      • you don't have internet access
      • you forgot to run / boot your web server
      • your web server isn't accessible
      • you have weird network configuration settings on your computer

      verify row content2:
      • CypressError: cy.visit() failed trying to load:

      https://pr-4338.pwa-venia.com/

      We attempted to make an http request to this URL but the request failed without a response.

      We received this error at the network level:

      Error: getaddrinfo ENOTFOUND pr-4338.pwa-venia.com

      Common situations why this would fail:

      • you don't have internet access
      • you forgot to run / boot your web server
      • your web server isn't accessible
      • you have weird network configuration settings on your computer

      verify row min height:
      • CypressError: cy.visit() failed trying to load:

      https://pr-4338.pwa-venia.com/

      We attempted to make an http request to this URL but the request failed without a response.

      We received this error at the network level:

      Error: getaddrinfo ENOTFOUND pr-4338.pwa-venia.com

      Common situations why this would fail:

      • you don't have internet access
      • you forgot to run / boot your web server
      • your web server isn't accessible
      • you have weird network configuration settings on your computer

      verify row video background:
      • CypressError: cy.visit() failed trying to load:

      https://pr-4338.pwa-venia.com/

      We attempted to make an http request to this URL but the request failed without a response.

      We received this error at the network level:

      Error: getaddrinfo ENOTFOUND pr-4338.pwa-venia.com

      Common situations why this would fail:

      • you don't have internet access
      • you forgot to run / boot your web server
      • your web server isn't accessible
      • you have weird network configuration settings on your computer

      verify row video background2:
      • CypressError: cy.visit() failed trying to load:

      https://pr-4338.pwa-venia.com/

      We attempted to make an http request to this URL but the request failed without a response.

      We received this error at the network level:

      Error: getaddrinfo ENOTFOUND pr-4338.pwa-venia.com

      Common situations why this would fail:

      • you don't have internet access
      • you forgot to run / boot your web server
      • your web server isn't accessible
      • you have weird network configuration settings on your computer

      verify row video background3:
      • CypressError: cy.visit() failed trying to load:

      https://pr-4338.pwa-venia.com/

      We attempted to make an http request to this URL but the request failed without a response.

      We received this error at the network level:

      Error: getaddrinfo ENOTFOUND pr-4338.pwa-venia.com

      Common situations why this would fail:

      • you don't have internet access
      • you forgot to run / boot your web server
      • your web server isn't accessible
      • you have weird network configuration settings on your computer
      ,should apply mediaQuery styles:
      • CypressError: cy.visit() failed trying to load:

      https://pr-4338.pwa-venia.com/

      We attempted to make an http request to this URL but the request failed without a response.

      We received this error at the network level:

      Error: getaddrinfo ENOTFOUND pr-4338.pwa-venia.com

      Common situations why this would fail:

      • you don't have internet access
      • you forgot to run / boot your web server
      • your web server isn't accessible
      • you have weird network configuration settings on your computer

Log

ERROR ON TASK: cypressTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against 30877b4

@pwa-studio-bot
Copy link
Collaborator

pwa-studio-bot commented Sep 30, 2024

Fails
🚫

node failed.

Log

ERROR ON TASK: cypressTests


Error:  Danger had errors running. See message(s) above for more details.
danger-results://tmp/danger-results.json

Generated by 🚫 dangerJS against 30877b4

@hafeez3000
Copy link

hafeez3000 commented Sep 30, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Progress: done version: Patch This changeset includes backwards compatible bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants