Skip to content

Commit

Permalink
Avoid security vulnerability with attribute target='_blank'
Browse files Browse the repository at this point in the history
Using this attribute unaccompanied by rel='noreferrer noopener' is a
severe security vulnerability according to
https://mathiasbynens.github.io/rel-noopener/.
The target='_blank' attributes should be accompanied with
rel='noreferrer noopener'.
  • Loading branch information
magjac committed Aug 21, 2018
1 parent 41ea642 commit c4f1424
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/KeyboardShortcutsDialog.js
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ class KeyboardShortcutsDialog extends React.Component {
</TableBody>
</Table>
<DialogContentText variant="body1">
For keyboard shortcuts in the text editor, please visit <a href="https://github.com/ajaxorg/ace/wiki/Default-Keyboard-Shortcuts" target="_blank">Ace Default Keyboard Shortcuts</a>
For keyboard shortcuts in the text editor, please visit <a href="https://github.com/ajaxorg/ace/wiki/Default-Keyboard-Shortcuts" target="_blank" rel="noreferrer noopener">Ace Default Keyboard Shortcuts</a>
</DialogContentText>
</DialogContent>
</Dialog>
Expand Down

0 comments on commit c4f1424

Please sign in to comment.