fix: correct GUIDerator size-bounds error message (20 is inclusive) - #451
Draft
nikolauspschuetz wants to merge 1 commit into
Draft
fix: correct GUIDerator size-bounds error message (20 is inclusive)#451nikolauspschuetz wants to merge 1 commit into
nikolauspschuetz wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GUIDerator.__init__guards withif size < 20 or size > 36, sosize == 20is accepted — and the docstring says "Lengths between 20 and 36 are considered valid". But the error message saysexpected 20 < size <= 36, excluding 20. SoGUIDerator(size=20)succeeds while the message claims 20 is invalid.Corrected the message to
20 <= size <= 36to match the check and the docstring. Added a regression test covering the inclusive lower bound and the message.