fix(notifications): fix dismiss function for tmc warnings #1956
+11
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Dej <meteyou@gmail.com>
dosubot
bot
added
the
size:S
rackrick
reviewed
Nov 4, 2024
|
|
||
| // return filtered tmcwarnings | ||
| return notifications.filter((entry) => { | ||
| return !tmcwarningsDismisses.includes(entry.id.substring(11)) |
There was a problem hiding this comment.
magic number... what is part of the string which starts at character 11?
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fix the dismiss function for TMC warnings in the notifications.
Related Tickets & Documents
fixes #1955
Mobile & Desktop Screenshots/Recordings
none
[optional] Are there any post-deployment tasks we need to perform?
none