-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for more keys #230
base: master
Are you sure you want to change the base?
Conversation
I'm not a developer on this project, but this sounds like a great addition. Tons of people are trying to figure out how to get maliit to provide a keyboard that is appropriate for a terminal. |
panel.activeKeypadState = "NORMAL" | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one especially, seems superfluous, as the Shift key already supports a lock state.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The caps lock key is only for completeness of a classical desktop layout.
import QtQuick 2.4 | ||
|
||
ActionKey { | ||
label: "esc" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If these buttons are to be included (is there a point, if nothing is using them?), they will definitely need better labels and icons. While esc
might fit on a single key, most of the things added here do not, and should probably have icons instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I mentioned, I wanted to use a icon for the tab key, but could not find any list of supported icon names. The names of page up/down keys can be shortened to pg up and pg dn. I also found out, that there exist symbols for home and end keys, but I have not seen them used yet. There would just be an issue with caps lock, as its symbol is already used with locked shift key. I am unsure how to solve this other than just having a wider key :).
I should have mentioned my motivation - I wanted to create a desktop terminal layout, but got stuck here #229. These keys seemed mature enough for a draft. I may close it, if you think I opened it too soon. |
Adds support for some keys, which would be required for a standard keyboard layout. Some notes: