Update deprecated ZMK keycodes #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR! Unfortunately that was because I had some commits in Miryoku Babel that should have been pushed. Pushed now. Other fixes welcome! |
|
That's even better, thanks for all the additions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I use miryoku_babel to edit my ZMK keymap, I notice some collateral differences between https://github.com/manna-harbour/miryoku_zmk/blob/master/miryoku/miryoku_babel/miryoku_layer_alternatives.h and https://github.com/manna-harbour/miryoku_babel/blob/master/tangled/zmk/miryoku_layer_alternatives.h, because of a change to update deprecated ZMK keycodes that got made in miryoku_zmk but not in miryoku_babel.
I haven't tried building my ZMK keymap with those deprecated (current miryoku_babel) keycodes --- I'm not sure what happens. This PR just updates miryoku_babel to match miryoku_zmk, eliminating those differences.
I included #5 in this PR so that the test workflow succeeds.