Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modify type definition in headers.ts #38

Merged
merged 10 commits into from
Sep 3, 2021
Merged

modify type definition in headers.ts #38

merged 10 commits into from
Sep 3, 2021

Conversation

qur786
Copy link
Contributor

@qur786 qur786 commented Aug 31, 2021

@maneetgoyal Sir , I have updated some type definition , and I have already updated rest of the definition in object Dereference .

@qur786 qur786 self-assigned this Aug 31, 2021
@qur786 qur786 linked an issue Aug 31, 2021 that may be closed by this pull request
Modify type definition in headers.ts #37
Closed
@maneetgoyal
Copy link
Contributor

Will look after #33 is tackled

@maneetgoyal maneetgoyal added this to the Upgrade 2.0 milestone Aug 31, 2021
@maneetgoyal
Copy link
Contributor

Lets try to fix this before #25

@qur786
Copy link
Contributor Author

qur786 commented Sep 2, 2021

Lets try to fix this before #25

Sir actually I am waiting a review from you .

@maneetgoyal
Copy link
Contributor

There was merge conflict so didn't review. Will start in a bit now.

maneetgoyal
maneetgoyal requested changes Sep 2, 2021
View reviewed changes
src/headers.ts Outdated Show resolved Hide resolved
src/headers.ts Outdated Show resolved Hide resolved
src/headers.ts Outdated Show resolved Hide resolved
tests/headers.test.ts Outdated Show resolved Hide resolved
maneetgoyal
maneetgoyal reviewed Sep 3, 2021
View reviewed changes
Copy link
Contributor

@maneetgoyal maneetgoyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor

src/headers.ts Outdated Show resolved Hide resolved
src/headers.ts Outdated Show resolved Hide resolved
@qur786
Copy link
Contributor Author

qur786 commented Sep 3, 2021

there is some problem with stereo0D sir , in the last commit I have wrote some comments about it , please check it @maneetgoyal sir

maneetgoyal
maneetgoyal approved these changes Sep 3, 2021
View reviewed changes
Copy link
Contributor

@maneetgoyal maneetgoyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@maneetgoyal
Copy link
Contributor

there is some problem with stereo0D sir , in the last commit I have wrote some comments about it , please check it @maneetgoyal sir

@qur786 Should be fixed now

@qur786
Copy link
Contributor Author

qur786 commented Sep 3, 2021

there is some problem with stereo0D sir , in the last commit I have wrote some comments about it , please check it @maneetgoyal sir

@qur786 Should be fixed now

yes sir

@qur786 qur786 merged commit 55ddeec into main Sep 3, 2021
@qur786 qur786 deleted the qur786/#37Modify-type-definition-in-headers.ts branch September 3, 2021 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maneetgoyal maneetgoyal maneetgoyal approved these changes

Assignees

@qur786 qur786

Labels
None yet
Projects
None yet
Milestone
Upgrade 2.0
Development

Successfully merging this pull request may close these issues.

Modify type definition in headers.ts
2 participants
@qur786 @maneetgoyal