Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisions for camera behavior, added basic gesture methods, separated… #19

Merged
merged 15 commits into from
Feb 8, 2024

Conversation

Archdoog
Copy link
Collaborator

@Archdoog Archdoog commented Feb 2, 2024

  • Updated GitHub runner to macos-14 to finally support #Preview
  • Adds pointfreeco snapshot testing for view testing. Still broken because async map style loading.
  • Adds @Mockable https://github.com/Kolos65/Mockable for mock testing.
  • Bumps maplibre iOS to latest
  • Adds basic framework for gesture handling.
  • Adds gesture models to capture gesture setup.
  • Adds user tracking behaviors to camera update.
  • Renames initialCamera to constantCamera to reflect behavior.
  • Adds Hashable to types that could be used when navigating to a MapView (e.g. MapCameraView).
  • Separates out MapView, Coordinator and Modifiers.
  • Maps MLNCameraChangeReason to swift representation of last reason.

TODO

  • Correct async map load for snapshot tests.

Closes #2
Closes #4

@Archdoog Archdoog marked this pull request as draft February 3, 2024 18:12
@ianthetechie
Copy link
Collaborator

Add tests

@Archdoog Archdoog self-assigned this Feb 6, 2024
@Archdoog Archdoog marked this pull request as ready for review February 8, 2024 01:18
@ianthetechie ianthetechie merged commit 364005b into maplibre:main Feb 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants