-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Gestures #30
Merged
Merged
Feature Gestures #30
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
import CoreLocation | ||
import MapLibre | ||
import MapLibreSwiftDSL | ||
import SwiftUI | ||
|
||
#Preview("Tappable Circles") { | ||
let tappableID = "simple-circles" | ||
return MapView(styleURL: demoTilesURL) { | ||
// Simple symbol layer demonstration with an icon | ||
CircleStyleLayer(identifier: tappableID, source: pointSource) | ||
.radius(16) | ||
.color(.systemRed) | ||
.strokeWidth(2) | ||
.strokeColor(.white) | ||
|
||
SymbolStyleLayer(identifier: "simple-symbols", source: pointSource) | ||
.iconImage(UIImage(systemName: "mappin")!.withRenderingMode(.alwaysTemplate)) | ||
.iconColor(.white) | ||
} | ||
.onTapMapGesture(on: [tappableID], onTapChanged: { _, features in | ||
print("Tapped on \(features.first)") | ||
}) | ||
.ignoresSafeArea(.all) | ||
} | ||
|
||
#Preview("Tappable Countries") { | ||
MapView(styleURL: demoTilesURL) | ||
.onTapMapGesture(on: ["countries-fill"], onTapChanged: { _, features in | ||
print("Tapped on \(features.first)") | ||
}) | ||
.ignoresSafeArea(.all) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to review this a bit further... Feels like there should be a slightly cleaner way...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this is a very specific fix and I didn't go deeper to check if there's any other setups we would need to check for.
MapLibre comes with 8 built in gestures, which also have own "require to fail" dependencies:
Since we don't want to expose the gesture recognizers or MapView to the user, I feel we have to help set up the gestures that a user adds to work with the built in gestures - just like SwiftUI where the motto is "convention over configuration" - the defaults should cover the most likely usage scenarios, ideally with a way of opting out of default behavior. So maybe we should add a further flag called "requireBuiltInGesturesToFail" which per default is true, but a user can set to false if they'd like their gestures to trigger regardless of the built in ones.
There are actually a total of 3 built in gesture recognizers that have
numberOfTapsRequired = 2
, so more code might be required, but in my testing, this code fixed the "user double tapped the map to zoom in, and yet the onMapGesture closure was run" problem, so I opted for the least invasive implementation for now.