Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce minimum OS versions & gitlab action testing CI #9

Merged
merged 21 commits into from
Nov 3, 2023
Merged

Reduce minimum OS versions & gitlab action testing CI #9

merged 21 commits into from
Nov 3, 2023

Conversation

Archdoog
Copy link
Collaborator

@Archdoog Archdoog commented Nov 2, 2023

  • Reduces minimum iOS & macOS target.
  • Splits macros from core code for testing.
  • Adds GitHub Action to run testing.

@Archdoog
Downgraded minimum iOS support to iOS 16
469cac9
@Archdoog
Merge pull request #1 from Rallista/ios-16-compat
e3656f9 
Downgraded minimum iOS support to iOS 16
@Archdoog
ios 15 compatiblity
c3a6b34
@Archdoog
Merge pull request #2 from Rallista/ios15-downgrade
7fc420a 
ios 15 compatiblity
@Archdoog
Initial test.yml
ae84f30
@Archdoog
Merge branch 'main' of github.com:Rallista/maplibre-swiftui-dsl-playg…
5258113 
…round into github-testing-action.yml
@Archdoog
added ci pipeline for xcodebuild test
937d67c
@Archdoog
added ci pipeline for xcodebuild test
0c0c682
@Archdoog
added ci pipeline for xcodebuild test
197dd04
@Archdoog
added ci pipeline for xcodebuild test
f00a373
@Archdoog
added ci pipeline for xcodebuild test
505ddbe
@Archdoog
added ci pipeline for xcodebuild test
77b9b16
@Archdoog
added ci pipeline for xcodebuild test
3451e21
@Archdoog
added ci pipeline for xcodebuild test
4a1fd96
@Archdoog
added ci pipeline for xcodebuild test
d24ee32
@Archdoog
added ci pipeline for xcodebuild test
b05f52f
@Archdoog
added ci pipeline for xcodebuild test
0ed50dd
@Archdoog
Merge pull request #3 from Rallista/github-testing-action.yml
529096f 
Added test.yml Github Action
@Archdoog Archdoog marked this pull request as draft November 2, 2023 14:38
@Archdoog Archdoog marked this pull request as ready for review November 2, 2023 14:39
ianthetechie
ianthetechie reviewed Nov 2, 2023
View reviewed changes
Copy link
Collaborator

@ianthetechie ianthetechie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change request. Thanks for this!

Also love how you prettified stuff a bit. I think eventually we'll add checks and a standard config for swiftformat or something.

Sources/MapLibreSwiftUI/Examples/Camera.swift Outdated Show resolved Hide resolved
@ianthetechie ianthetechie merged commit 6199f3f into maplibre:main Nov 3, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianthetechie ianthetechie ianthetechie left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Archdoog @ianthetechie