Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP/RFC: use hookwrapper to handle items in the end #8

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Feb 9, 2017

This allows for proper grouping when using e.g. -k: items will be
narrowed down already by then.

TODO:

  • will throw an "Invalid test-group argument" when -k selects
    only a single test and you use test-group-count=2 test-group=2.

@s0undt3ch
Copy link
Contributor

This also applies to markers.

@blueyed please update to latest master branch in order for the CI process to run till the end. You seem to have created this PR from an older commit.

This allows for proper grouping when using e.g. `-k`: items will be
narrowed down already by then.

TODO:
 - [ ] will throw an "Invalid test-group argument" when `-k` selects
   only a single test and you use test-group-count=2 test-group=2.
@@ -1,4 +1,7 @@
import math
from random import Random
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double import

@blueyed
Copy link
Contributor Author

blueyed commented Jul 29, 2018

This also applies to markers.

What does it mean? Does it need more changes?

I am not using this plugin myself - I've gone with a custom approach to splitting in pytest_collection_modifyitems.

Feel free to close it, or pick it up yourself.

@s0undt3ch
Copy link
Contributor

I've also gone custom since this plugin is not being maintained, apparently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants