feat: martian-pipestance crate #486
Annotations
10 warnings
martian/src/mro.rs#L36
warning: variables can be used directly in the `format!` string
--> martian/src/mro.rs:36:17
|
36 | / assert!(
37 | | width >= min_width,
38 | | "Need a minimum width of {}. Found {}",
39 | | min_width,
40 | | width
41 | | );
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
= note: requested on the command line with `-W clippy::uninlined-format-args`
|
martian/src/mro.rs#L444
warning: variables can be used directly in the `format!` string
--> martian/src/mro.rs:444:13
|
444 | / assert!(
445 | | self.name != token,
446 | | "Martian token {} cannot be used as field name",
447 | | token
448 | | );
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
martian/src/mro.rs#L844
warning: variables can be used directly in the `format!` string
--> martian/src/mro.rs:844:13
|
844 | / write!(
845 | | f,
846 | | "{params:<ty_width$}",
847 | | params = chunk_in_out,
848 | | ty_width = ty_width
849 | | )?;
| |_____________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
martian/src/lib.rs#L360
warning: variables can be used directly in the `format!` string
--> martian/src/lib.rs:360:9
|
360 | / assert!(
361 | | header_comment
362 | | .lines()
363 | | .all(|line| line.trim_end().is_empty() || line.starts_with('#')),
364 | | "All non-empty header lines must start with '#', but got\n{}",
365 | | header_comment
366 | | );
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
martian-derive/src/lib.rs#L325
warning: variables can be used directly in the `format!` string
--> martian-derive/src/lib.rs:325:9
|
325 | / format!(
326 | | "{}. You are trying to use it on {} trait implementation.",
327 | | ATTR_NOT_ON_TRAIT_IMPL_ERROR, last_ident
328 | | ),
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
= note: requested on the command line with `-W clippy::uninlined-format-args`
|
martian-derive/src/lib.rs#L488
warning: variables can be used directly in the `format!` string
--> martian-derive/src/lib.rs:488:45
|
488 | / ... format!(
489 | | ... "{}. Found {}",
490 | | ... INVALID_MRO_TYPE_ERROR, val_string
491 | | ... ),
| |_______________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
martian-derive/src/lib.rs#L520
warning: variables can be used directly in the `format!` string
--> martian-derive/src/lib.rs:520:17
|
520 | / format!(
521 | | "Field name {} is not allowed here since it is a martian keyword",
522 | | name
523 | | ),
| |_________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
|
martian-pipestance/src/critical_path.rs#L261
warning: variables can be used directly in the `format!` string
--> martian-pipestance/src/critical_path.rs:261:9
|
261 | println!("{:#?}", critical_path);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
= note: requested on the command line with `-W clippy::uninlined-format-args`
help: change this to
|
261 - println!("{:#?}", critical_path);
261 + println!("{critical_path:#?}");
|
|
martian-pipestance/src/critical_path.rs#L303
warning: redundant closure
--> martian-pipestance/src/critical_path.rs:303:48
|
303 | StageWeight::CustomWeight(Box::new(|p| p.observed_wall_time())),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the method itself: `perf::PerfElement::observed_wall_time`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_for_method_calls
= note: requested on the command line with `-W clippy::redundant-closure-for-method-calls`
|
martian-pipestance/src/critical_path.rs#L305
warning: variables can be used directly in the `format!` string
--> martian-pipestance/src/critical_path.rs:305:9
|
305 | println!("{:#?}", critical_path);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
help: change this to
|
305 - println!("{:#?}", critical_path);
305 + println!("{critical_path:#?}");
|
|
The logs for this run have expired and are no longer available.
Loading