New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update to peotry as a buildsystem and update dependencies #22

Merged

hechth merged 13 commits into matchms:main from hechth:dependency_updates

Nov 5, 2024

Collaborator

hechth commented Nov 4, 2024

This PR updates the buildsystem to use poetry and also updates the dependencies of the package to higher versions, including numpy 2.


          update to peotry as a buildsystem

92b5b30

hechth changed the title ~~update to peotry as a buildsystem~~ update to peotry as a buildsystem and update dependencies


          updated workflows and version

9b515f3

hechth closed this

hechth reopened this


          fied python 3.10

5c38853

hechth closed this

hechth reopened this


          added dev deps and changed prospector run to poetry

0e2d3c2

hechth closed this

hechth reopened this


          suppressed linter warnings

2539b4b

hechth closed this

hechth reopened this


          added poetry run to isort statement

845076b

hechth closed this

hechth reopened this

hechth added 2 commits

November 4, 2024 17:13


          added twine to dev deps

3725ed3


          limited python to <3.13

cd56a08

hechth closed this

hechth reopened this


          reset python version

f41fbd8

hechth closed this

hechth reopened this


          added poetry lock statement

d41b331

hechth closed this

hechth reopened this

Collaborator

florian-huber commented Nov 5, 2024 •

edited

Loading

We could also switch from pylint to ruff as we just also did for MS2DeepScore.

The workflow would need something like this:

      - name: Check style against standards using Ruff
        run: ruff check .

And we could add a config file ruff.toml or .ruff.toml, e.g. like this ruff.toml. In principle this should also work with something like tool.ruff in the existing toml-file.


          added lock statements

e211711

hechth closed this

hechth reopened this

hechth added 2 commits

November 5, 2024 08:52


          removed twine from dev deps

70ec42d


          removed test with conda and removed twine as dev dep

8198a0a

hechth closed this

hechth reopened this

Collaborator Author

hechth commented Nov 5, 2024

@florian-huber I think this should be ready as a first step :)

hechth mentioned this pull request

switch from pylint to ruff #24

Open

Collaborator Author

hechth commented Nov 5, 2024

We could also switch from pylint to ruff as we just also did for MS2DeepScore.

The workflow would need something like this:
      - name: Check style against standards using Ruff
        run: ruff check .
And we could add a config file ruff.toml or .ruff.toml, e.g. like this ruff.toml. In principle this should also work with something like tool.ruff in the existing toml-file.

I've referenced this in a new issue, so we can address this separately.

hechth requested a review from florian-huber

November 5, 2024 09:20

florian-huber approved these changes

View reviewed changes

Collaborator

florian-huber left a comment

Looks good to me @hechth, thanks!

hechth merged commit dfb6a31 into matchms:main

11 checks passed

hechth mentioned this pull request

Update Python and dependencies #21

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet