Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force analyze files #739

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

36grad
Copy link

@36grad 36grad commented Apr 8, 2024

Add an option (--force_analyze_files) that enablee the user to explicitly (re-)analyze specific files.

- The  --force_analyze_files option allows the user to specify files that they want to analyze.
- The  --force_analyze_files (or -f) option can be used multiple times to analyze more than one file.
- The images must be given relative to the data/USER_ID/files folder and thus the --user_id option is required.
- The  --force_analyze_files option does not work together with sync-mode or cluster-mode.
- If no mode is specified by the user, defer-mode is enabled for a better user experience.
- Files that are specified using the  --force_analyze_files option are put at the front of the analysis queue and thus are analyzed first.

- The  --force_analyze_files option allows the user to specify files that they want to analyze.
- The  --force_analyze_files (or -f) option can be used multiple times to analyze more than one file.
- The images must be given relative to the data/USER_ID/files folder and thus the --user_id option is required.
- The  --force_analyze_files option does not work together with sync-mode or cluster-mode.
- If no mode is specified by the user, defer-mode is enabled for a better user experience.
- Files that are specified using the  --force_analyze_files option are put at the front of the analysis queue and thus are analyzed first.
@matiasdelellis
Copy link
Owner

Hi @36grad
Again, Thanks for this PR.

Can I ask you for a change in approach to the problem?. Instead of adding a force option, (which ultimately resets the file), wouldn't it be better to add an option to face:reset to reset files? 🥲

@36grad
Copy link
Author

36grad commented Apr 23, 2024

Yep, that is a good suggestion - I had worked initially based on the PHP code from the appstore version and when I pulled the latest source from the repository I saw that I had to add a code line where I reset the file's status - so this would have been a good approach in the first place.
There's one thing, however, which I would be missing is having the option to explicitly analyze those files. If they're only reset there's still a huge number of files to be analyzed there's no way to tell when the reset files will be analyzed. Any ideas here?

@matiasdelellis
Copy link
Owner

If they're only reset there's still a huge number of files to be analyzed there's no way to tell when the reset files will be analyzed. Any ideas here?

MMm.. 🤔
In any case you could add a --path option and you become a hero!. 😉
In the end you will reuse a lot of what you made, but IMHO it makes makes more sense to reset and scan explicitly instead of forcing something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants