Bath v2: Get face descriptors only when needed in batches #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are no significant advantages beyond improving the code, but I do this in preparation for the next commit.
In my tests with 37128 faces and a batch size of 5000 it improves memory consumption by 38,81%. I guess we can celebrate a little. 🎉 😉
In my tests this improves memory consumption by another 3.14%. In total against version 0.9.51 we achieved an improvement of 41.89%.
1.10 % less memory, totaling 42,99 % reduction..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a small change, which was in consideration for a long time, but I needed to try it.. 🙈 😅
In my tests with 37128 faces and a batch size of 5000 it improves
memory consumption by 38,81%.
I guess we can celebrate a little. 🎉 😉