Skip to content

Commit

Permalink
Add type checking to Github Actions
Browse files Browse the repository at this point in the history
  • Loading branch information
matinone committed Dec 8, 2023
1 parent ba36e09 commit 92fb35e
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions .github/workflows/python-app.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@ jobs:
- name: Lint with Ruff
run: |
poetry poe lint
- name: Type check with Mypy
run: |
poetry poe typecheck
- name: Test with Pytest
run: |
poetry poe test
1 change: 0 additions & 1 deletion app/tests/api/test_quiz.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
from app.tests.factories.quiz_factory import QuizFactory


# add test with missing title/description
@pytest.mark.parametrize("cases", ["full", "no_title", "no_description"])
async def test_create_quiz(client: AsyncClient, db_session: AsyncSession, cases: str):
quiz_data = {"title": "My quiz", "description": "My quiz description"}
Expand Down
1 change: 1 addition & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -76,4 +76,5 @@ start = "python app/main.py"
test = "pytest app/tests/ -v --cov --cov-report=term-missing"
lint = "ruff check ."
format = "ruff format ."
typecheck = "mypy ./app"
precommit = "pre-commit run --all-files"

0 comments on commit 92fb35e

Please sign in to comment.