refactor(base): Remove impl From for SyncTimelineEvent
#4146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnjbvr
reviewed
Oct 17, 2024
richvdh
force-pushed
the
rav/remove_impl_from
branch
from
143a27c
to
4abeb17
Compare
richvdh
commented
Oct 17, 2024
| @@ -183,15 +183,15 @@ impl TestTimeline { | |||
| C: RedactedMessageLikeEventContent, | |||
| { | |||
| let ev = self.event_builder.make_sync_redacted_message_event(sender, content); | |||
| self.handle_live_event(Raw::new(&ev).unwrap().cast()).await; | |||
There was a problem hiding this comment.
given that ev was already a Raw<AnySyncTimelineEvent>, I don't know what the whole Raw::new(&ev).unwrap().cast() was supposed to achieve here. I think we can just get rid of it.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4146 +/- ##
==========================================
- Coverage 84.76% 84.73% -0.04%
==========================================
Files 269 269
Lines 28848 28841 -7
==========================================
- Hits 24453 24437 -16
- Misses 4395 4404 +9 ☔ View full report in Codecov by Sentry. |
I feel like the ability to convert straight from a `Raw<AnySyncTimelineEvent>>` into a `SyncTimelineEvent` is somewhat over-simplified: the two are only occasionally equivalent, and it's better to be explicit. Changelog: `SyncTimelineEvent` no longer implements `From<Raw<AnySyncTimelineEvent>>`.
richvdh
force-pushed
the
rav/remove_impl_from
branch
from
e1b250a
to
b2d3897
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I feel like the ability to convert straight from a
Raw<AnySyncTimelineEvent>>into aSyncTimelineEventis somewhat over-simplified: the two are only occasionally equivalent, and it's better to be explicit.