Commits on Aug 31, 2023

1. Fix stderr not printing in TestGoGenerateVendoredPackages …

   Before this commit, the TestGoGenerateVendoredPackages test failed to
   print stderr to the terminal as expected. Stderr was not printed because
   the test expected ExitError.Stderr to be populated. Per documentation
   [ExitError.Stderr] is only populated by the [Cmd.Output] method,
   which the test does not use. With this commit, the test uses a buffer to
   record stderr and include it in the failed test message as previously
   intended.
   
   This issue was discovered because the TestGoGenerateVendoredPackages
   test expects moq to be available in the PATH. That means that running
   tests (go test ./...) in this project without first installing moq (go
   install) results in the TestGoGenerateVendoredPackages test to fail.
   
   Before this commit, the error message looked as follows:
   
       --- FAIL: TestGoGenerateVendoredPackages (0.03s)
           moq_test.go:635: Wait: exit status 1
   
   This error message does not include the output from stderr, making it
   difficult to know why the test is failing.
   
   With this commit, the error message looks as follows:
   
       --- FAIL: TestGoGenerateVendoredPackages (0.03s)
           moq_test.go:641: Wait: exit status 1 user/user.go:5: running
           "moq": exec: "moq": executable file not found in $PATH
   
   [ExitError.Stderr]: https://pkg.go.dev/os/exec#ExitError
   [Cmd.Output]: https://pkg.go.dev/os/exec#Cmd.Output

   

   samherrmann committed Aug 31, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 32dc8f1
   • Browse repository at this point

   Copy the full SHA

   32dc8f1 View commit details

   Browse the repository at this point in the history