Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support imported type aliases #225

Merged
merged 3 commits into from
Aug 24, 2024
Merged

support imported type aliases #225

merged 3 commits into from
Aug 24, 2024

Commits on Aug 23, 2024

  1. support imported type aliases

    Go 1.23 changed how go/types handles type aliases, which breaks code generation if you use a package that has an alias type (example: https://pkg.go.dev/github.com/golang/protobuf@v1.5.3/ptypes/timestamp#Timestamp). These were getting generated as just the unqualified name, without the package. If you used a previous version of Go, it meant that if that aliased type was in an internal package we'd try to import the internal package instead, resulting in a compilation error.
    
    Add a switch to handle that case, and bump the go.mod version to support using types.Alias.
    reillywatson committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    a024924 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2024

  1. Configuration menu
    Copy the full SHA
    c7f4a31 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c110da7 View commit details
    Browse the repository at this point in the history