Merge pull request #14 from matter-labs/UEXP-4541-display-unknown-tokens

fix: display unknown for transfers with unknown tokens
matter-labs · Sep 22, 2023 · 0ca1390 · 0ca1390
2 parents 2f9430d + 03ad1e9
commit 0ca1390
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 2 deletions.
diff --git a/packages/app/.eslintignore b/packages/app/.eslintignore
@@ -0,0 +1 @@
+dist
diff --git a/packages/app/src/composables/useTransfers.ts b/packages/app/src/composables/useTransfers.ts
@@ -18,6 +18,13 @@ export default (address: ComputedRef<string>, context = useContext()) => {
       ),
     (transfer: Api.Response.Transfer): Transfer => ({
       ...transfer,
+      token: transfer.token || {
+        l2Address: transfer.tokenAddress,
+        l1Address: null,
+        name: null,
+        symbol: null,
+        decimals: 0,
+      },
       fromNetwork: transfer.type === "deposit" ? "L1" : "L2",
       toNetwork: transfer.type === "withdrawal" ? "L1" : "L2",
     })

diff --git a/packages/app/tests/composables/useTransfers.spec.ts b/packages/app/tests/composables/useTransfers.spec.ts
@@ -30,11 +30,12 @@ vi.mock("ohmyfetch", () => {
       Promise.resolve({
         items: [
           { ...baseTransferPayload, type: "transfer" },
+          { ...baseTransferPayload, token: null, type: "transfer" },
           { ...baseTransferPayload, type: "deposit" },
           { ...baseTransferPayload, type: "withdrawal" },
         ],
         meta: {
-          totalItems: 3,
+          totalItems: 4,
           page: 1,
           pageSize: 10,
           totalPages: 1,
@@ -73,14 +74,27 @@ describe("useTransfers:", () => {
     const composable = useTransfers(address);
     await composable.load(1);
     const transfers = composable.data.value;
-    expect(composable.data.value?.length).toBe(3);
+    expect(composable.data.value?.length).toBe(4);
     expect(transfers).toEqual([
       {
         ...baseTransferPayload,
         type: "transfer",
         fromNetwork: "L2",
         toNetwork: "L2",
       },
+      {
+        ...baseTransferPayload,
+        token: {
+          decimals: 0,
+          l1Address: null,
+          l2Address: "tokenAddress",
+          name: null,
+          symbol: null,
+        },
+        type: "transfer",
+        fromNetwork: "L2",
+        toNetwork: "L2",
+      },
       {
         ...baseTransferPayload,
         type: "deposit",