Feature/hk stx bitflow receiver v1 - #23
Conversation
|
@unixwhisperer is attempting to deploy a commit to the matt glory's projects Team on Vercel. A member of the Team first needs to authorize it. |
mattglory
left a comment
There was a problem hiding this comment.
Thanks Hillary — contract and docs review both approved. Two requests before merge: (1) please remove the .beads/ directory — it's your personal tooling and doesn't belong in the main repo. (2) The session handoff files under project-docs/session-handoffs/ are your internal working docs — happy to keep if you want them on record, but flag if you'd prefer they stay off main. Once cleaned up this is ready to merge. The docs-feedback-report findings are exactly what the protocol needs.
External-integrator feedback (PR #23) surfaced 4 real DX bugs; fixed all: - Sugar trap: warn that in-repo examples use .flashstack-stx-core sugar (resolves to deployer address) — external deploys must use absolute principals - Seed requirement: new 'Do You Need a Seed?' section — a 0-balance receiver can't cover the fee+slippage on a break-even strategy - Read-only gotcha: show how to write estimate-repayment; a define-constant core principal is rejected inside define-read-only (must inline the literal) - clarinet check coverage: clarify it only type-checks contracts in Clarinet.toml, not script-deployed receivers Also strips the false 'first flash loan protocol' claim (Zest predates on Stacks) from INTEGRATION_GUIDE, package.json, CONTRIBUTING; scopes CHANGELOG 'first' to FlashStack's own milestones. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Update: the 4 findings in your
To land this PR (recapping + a couple additions):
Two optional, non-blocking suggestions for the contract itself:
Great work — real integrator feedback that made the protocol better. |
… receiver External-developer flash-loan receiver that borrows STX from flashstack-stx-core, executes a real STX->stSTX->STX round-trip on the Bitflow stableswap pool, and repays principal + fee atomically. Combines the contract-caller gate from hk-stx-real-receiver-v2 with the Bitflow round-trip logic from bitflow-arb-receiver-v4. Deployed under an external wallet, so all cross-contract references use absolute mainnet principals.
1003bb9 to
42a9f6a
Compare
Description
Type of Change
Related Issues
Fixes #
Related to #
Changes Made
Testing Performed
Manual Testing
clarinet checkclarinet consoleAutomated Testing
Test Commands Run
# List the commands you ran to test clarinet check clarinet console3Test Results
Checklist
Code Quality
Documentation
Testing
Security & Safety
Screenshots (if applicable)
Additional Context
Deployment Considerations