Skip to content

Commit

Permalink
test moodlehq#3
Browse files Browse the repository at this point in the history
  • Loading branch information
matthewhilton committed Aug 9, 2024
1 parent 8b1b5ae commit 4225bcc
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/Installer/VendorInstaller.php
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ public function installNode(): void
Process::fromShellCommandline($cmd, $this->moodle->directory, null, null, null)
);
if (!$process->isSuccessful()) {
throw new \RuntimeException('Node.js installation failed. Output: ' . $process->getOutput());
throw new \RuntimeException('Node.js installation failed. Output: ' . $process->getOutput() . ' nvm dir: ' . $nvmDir);

Check failure on line 129 in src/Installer/VendorInstaller.php

View workflow job for this annotation

GitHub Actions / CI test (make validate)

PossiblyFalseOperand

src/Installer/VendorInstaller.php:129:122: PossiblyFalseOperand: Cannot concatenate with a possibly false false|string (see https://psalm.dev/162)
}
// Retrieve NVM_BIN from initialisation output, we will use it to
// substitute right Node.js environment in all future process runs.
Expand Down

0 comments on commit 4225bcc

Please sign in to comment.