Skip to content
This repository has been archived by the owner on Feb 22, 2024. It is now read-only.

Making overholt work with recent dependencies #23

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

arnuschky
Copy link

  1. update of tests
    • adjust model factories to new Factory-Boy
    • enable login system for recent Flask-Login (disabled by default
      for tests)
    • obtain CSRF token from login form using Flask-Fillin (old method
      didn't work anymore)
  2. update of forms imports for new wtf
  3. update all dependencies

 1) update of tests
    - adjust model factories to new Factory-Boy
    - enable login system for recent Flask-Login (disabled by default
      for tests)
    - obtain CSRF token from login form using Flask-Fillin (old method
      didn't work anymore)
 2) update of forms imports for new wtf
 3) update all dependencies
@mattupstate
Copy link
Owner

@arnuschky Thanks for taking the time to do this. My only criticism is that flask.ext is going to be deprecated. There's no reason to use it.

@peterdemin
Copy link

@mattupstate, why you say flask.ext is going to be deprecated? I see http://flask.pocoo.org/docs/extensiondev/#extension-import-transition says it's ok.

@mattupstate
Copy link
Owner

@arnuschky
Copy link
Author

Ah really? I thought it's the other way 'round. :)
Will fix it tonight.

@arnuschky
Copy link
Author

I tested this, but none of the release version of the different flask extensions used by overholt seem to support this. It's a recent change, I guess we have to wait for it to trickle down.
(flask-security is among them, btw)

@mattupstate
Copy link
Owner

@arnuschky I'm sorry, but I'm not sure I understand. I use flask_<extension_name> in all my projects.

@arnuschky
Copy link
Author

Ah, I misunderstood, sorry. I thought that it changes to flask_ext.<extension_name>. Works now.

  1) update of tests
     - adjust model factories to new Factory-Boy
     - enable login system for recent Flask-Login (disabled by default for tests)
     - obtain CSRF token from login form using Flask-Fillin (old method didn't work anymore)
  2) update of forms imports for new wtf
  3) update all dependencies
  4) flask.ext.<name> -> flask_<name>
@arnuschky
Copy link
Author

Rebased previous commits, removed accidentally committed changes to config files.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants