Replace expires cookie attribute with max-age attribute #823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Repository owner
deleted a comment from
sebastiaguevara
Nov 22, 2023
|
Why not use both? That's what Django seems to do. |
tvuotila
force-pushed
the
feat/cookie-max-age-instead-of-expires
branch
from
cc2bfb1
to
b792120
Compare
I checked the Not using both has these benefits:
|
tvuotila
force-pushed
the
feat/cookie-max-age-instead-of-expires
branch
from
b792120
to
376ea72
Compare
I investigated this more and Flask also uses both:
Thus, in the end, this PR sets both, |
maxcountryman
requested changes
Jan 22, 2024
| @@ -17,6 +17,7 @@ Unreleased | |||
| - Use `datetime.now(timezone.utc)` instead of deprecated `datetime.utcnow`. #758 | |||
| - Never look at the `X-Forwarded-For` header, always use `request.remote_addr`, | |||
| requiring the developer to configure `ProxyFix` appropriately. #700 | |||
| - Replace `expires` attribute with `max-age` in "remember_me" cookie. #823 | |||
There was a problem hiding this comment.
This should read as additive since it's no longer replacing.
| @@ -654,11 +647,8 @@ def test_remember_me_custom_duration_uses_custom_cookie(self): | |||
| c.get("/login-notch-remember-custom") | |||
| cookie = c.get_cookie(name, domain, path) | |||
| self.assertIsNotNone(cookie) | |||
| self.assertIsNotNone(cookie.expires) | |||
There was a problem hiding this comment.
This shouldn't be removed. Likewise below.
| @@ -693,19 +680,6 @@ def login_notch_remember_custom_invalid(): | |||
| result = c.get("/login-notch-remember-custom-invalid") | |||
| self.assertEqual(result.status_code, 500) | |||
|
|
|||
| def test_set_cookie_with_invalid_duration_raises_exception(self): | |||
There was a problem hiding this comment.
Why is this being removed?
|
|
||
| def test_remember_me_refresh_each_request(self): | ||
| with patch("flask_login.login_manager.datetime") as mock_dt: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internet Explorer doesn't support max-age cookie attribute. I don't know any other reason to use expires instead of max-age.I was checking wrong "max-age". Even Internet Explorer supports max-age since IE 9 (source)Max-age works even if client or server clocks have wrong time.