-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add monitor detection fallback to skip cap check #102
Conversation
Hahaha thanks 😁 Most importantly, do you confirm that this trick solves the issue with your monitors? Just to be sure 😄 |
While I totally agree with "twice is not duplication", rust is very pleasant language to build abstractions on 😁 What do you think about the idea I just pushed? And does it actually work? 😅 |
Oh, your approach is much better! That's pretty much what I was thinking would be the best solution but I didn't quite know how to implement it. I can confirm that
Ignoring all the DDC/CI errors of course, it can read brightness changes from both monitors. |
That's awesome! Glad that we are on the same page, and that it works as expected, merging then, and thanks for all your help! 🙏 |
Resolves #101
I'm a total Rust newb - if there's a better way to do this let me know. I basically copied everything from
find_display_by_name
and skipped the capabilities check. Not the prettiest but it's only twice.Personally, I'm a fan of "twice is not duplication" ;)