Skip to content

Commit

Permalink
fix: do not use uv on PyPy 3.8
Browse files Browse the repository at this point in the history
uv 0.2.25+ does not work with PyPy 3.8
Given PyPy 3.8 is EOL, just disable uv for this config rather than ask for it to be supported again in uv.
  • Loading branch information
mayeut committed Jul 20, 2024
1 parent de84624 commit d25fe00
Showing 1 changed file with 8 additions and 4 deletions.
12 changes: 8 additions & 4 deletions cibuildwheel/windows.py
Original file line number Diff line number Diff line change
Expand Up @@ -254,8 +254,10 @@ def setup_python(
raise ValueError(msg)
assert base_python.exists()

use_uv = build_frontend == "build[uv]" and Version(python_configuration.version) >= Version(
"3.8"
use_uv = (
build_frontend == "build[uv]"
and Version(python_configuration.version) >= Version("3.8")
and not python_configuration.identifier.startswith("pp38-")
)
uv_path = find_uv()

Expand Down Expand Up @@ -366,8 +368,10 @@ def build(options: Options, tmp_path: Path) -> None:
for config in python_configurations:
build_options = options.build_options(config.identifier)
build_frontend = build_options.build_frontend or BuildFrontendConfig("pip")
use_uv = build_frontend.name == "build[uv]" and Version(config.version) >= Version(
"3.8"
use_uv = (
build_frontend.name == "build[uv]"
and Version(config.version) >= Version("3.8")
and not config.identifier.startswith("pp38-")
)
log.build_start(config.identifier)

Expand Down

0 comments on commit d25fe00

Please sign in to comment.