FIX 002 alembic migration file patch

* remove static service id lookup creation. it seems like its already
  there.
* remove unique constraint on vehicle trips. the 001 migration is
  correct, but it needs to be defined in the schema.
* redifine the unique constraint in the schema.
* drop and re-add the `opmi_all_rt_fields_joined` view. we cannot alter
  the components of the view without redefining it.

python_src/src/lamp_py/migrations/versions/performance_manager_prod/002_1b53fd278b10_fix_trip_id_length.py

@@ -6,14 +6,14 @@
 
 Details
 * upgrade -> change "trip_id" field from length 128 to 512
-* upgrade -> add static service id lookup table
-
 * downgrade -> change "trip_id" field from length 512 to 128
-* downgrade -> drop static service id lookup table 
 """
 from alembic import op
 import sqlalchemy as sa
 
+from lamp_py.migrations.versions.performance_manager_prod.sql_strings.strings_001 import (
+    view_opmi_all_rt_fields_joined,
+)
 
 # revision identifiers, used by Alembic.
 revision = "1b53fd278b10"
@@ -24,15 +24,7 @@
 
 def upgrade() -> None:
     # ### commands auto generated by Alembic - please adjust! ###
-    op.create_table(
-        "static_service_id_lookup",
-        sa.Column("dummy_pk", sa.Integer(), nullable=False),
-        sa.Column("route_id", sa.String(length=60), nullable=True),
-        sa.Column("service_id", sa.String(length=60), nullable=True),
-        sa.Column("service_date", sa.Integer(), nullable=True),
-        sa.Column("static_version_key", sa.Integer(), nullable=True),
-        sa.PrimaryKeyConstraint("dummy_pk"),
-    )
+    op.execute("DROP VIEW IF EXISTS opmi_all_rt_fields_joined;")
     op.alter_column(
         "static_route_patterns",
         "representative_trip_id",
@@ -75,27 +67,13 @@ def upgrade() -> None:
         type_=sa.String(length=512),
         existing_nullable=True,
     )
-    op.drop_constraint(
-        "vehicle_trips_unique_trip", "vehicle_trips", type_="unique"
-    )
-    op.create_unique_constraint(
-        "vehicle_trips_unique_trip",
-        "vehicle_trips",
-        ["service_date", "trip_id"],
-    )
+    op.execute(view_opmi_all_rt_fields_joined)
     # ### end Alembic commands ###
 
 
 def downgrade() -> None:
     # ### commands auto generated by Alembic - please adjust! ###
-    op.drop_constraint(
-        "vehicle_trips_unique_trip", "vehicle_trips", type_="unique"
-    )
-    op.create_unique_constraint(
-        "vehicle_trips_unique_trip",
-        "vehicle_trips",
-        ["service_date", "route_id", "trip_id"],
-    )
+    op.execute("DROP VIEW IF EXISTS opmi_all_rt_fields_joined;")
     op.alter_column(
         "vehicle_trips",
         "static_trip_id_guess",
@@ -138,5 +116,5 @@ def downgrade() -> None:
         type_=sa.VARCHAR(length=128),
         existing_nullable=False,
     )
-    op.drop_table("static_service_id_lookup")
+    op.execute(view_opmi_all_rt_fields_joined)
     # ### end Alembic commands ###

python_src/src/lamp_py/migrations/versions/performance_manager_staging/002_1b53fd278b10_fix_trip_id_length.py

@@ -6,14 +6,14 @@
 
 Details
 * upgrade -> change "trip_id" field from length 128 to 512
-* upgrade -> add static service id lookup table
-
 * downgrade -> change "trip_id" field from length 512 to 128
-* downgrade -> drop static service id lookup table 
 """
 from alembic import op
 import sqlalchemy as sa
 
+from lamp_py.migrations.versions.performance_manager_staging.sql_strings.strings_001 import (
+    view_opmi_all_rt_fields_joined,
+)
 
 # revision identifiers, used by Alembic.
 revision = "1b53fd278b10"
@@ -24,15 +24,7 @@
 
 def upgrade() -> None:
     # ### commands auto generated by Alembic - please adjust! ###
-    op.create_table(
-        "static_service_id_lookup",
-        sa.Column("dummy_pk", sa.Integer(), nullable=False),
-        sa.Column("route_id", sa.String(length=60), nullable=True),
-        sa.Column("service_id", sa.String(length=60), nullable=True),
-        sa.Column("service_date", sa.Integer(), nullable=True),
-        sa.Column("static_version_key", sa.Integer(), nullable=True),
-        sa.PrimaryKeyConstraint("dummy_pk"),
-    )
+    op.execute("DROP VIEW IF EXISTS opmi_all_rt_fields_joined;")
     op.alter_column(
         "static_route_patterns",
         "representative_trip_id",
@@ -75,27 +67,13 @@ def upgrade() -> None:
         type_=sa.String(length=512),
         existing_nullable=True,
     )
-    op.drop_constraint(
-        "vehicle_trips_unique_trip", "vehicle_trips", type_="unique"
-    )
-    op.create_unique_constraint(
-        "vehicle_trips_unique_trip",
-        "vehicle_trips",
-        ["service_date", "trip_id"],
-    )
+    op.execute(view_opmi_all_rt_fields_joined)
     # ### end Alembic commands ###
 
 
 def downgrade() -> None:
     # ### commands auto generated by Alembic - please adjust! ###
-    op.drop_constraint(
-        "vehicle_trips_unique_trip", "vehicle_trips", type_="unique"
-    )
-    op.create_unique_constraint(
-        "vehicle_trips_unique_trip",
-        "vehicle_trips",
-        ["service_date", "route_id", "trip_id"],
-    )
+    op.execute("DROP VIEW IF EXISTS opmi_all_rt_fields_joined;")
     op.alter_column(
         "vehicle_trips",
         "static_trip_id_guess",
@@ -138,5 +116,5 @@ def downgrade() -> None:
         type_=sa.VARCHAR(length=128),
         existing_nullable=False,
     )
-    op.drop_table("static_service_id_lookup")
+    op.execute(view_opmi_all_rt_fields_joined)
     # ### end Alembic commands ###

python_src/src/lamp_py/postgres/postgres_schema.py

@@ -121,6 +121,7 @@ class VehicleTrips(SqlBase):  # pylint: disable=too-few-public-methods
     __table_args__ = (
         sa.UniqueConstraint(
             service_date,
+            route_id,
             trip_id,
             name="vehicle_trips_unique_trip",
         ),