feat: CSV Flatfile Pipeline Testing #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rymarczy
force-pushed
the
testing_with_flat_file
branch
from
c195dc4
to
da80368
Compare
mzappitello
suggested changes
Jul 19, 2023
| parquet_file = os.path.join( | ||
| springboard_dir, parquet_folder, "flat_file.parquet" | ||
| ) | ||
| os.makedirs(os.path.join(springboard_dir, parquet_folder), exist_ok=True) |
There was a problem hiding this comment.
we should use the pytest temp directory fixture instead of os mkdir.
There was a problem hiding this comment.
Incorporated with pytest temp_path fixture.
| ) | ||
|
|
||
| compare_result = db_result_df.compare(csv_result_df, align_axis=1) | ||
| print(compare_result, flush=True) |
There was a problem hiding this comment.
only print this if the assert fails?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a new testing method
test_whole_table. This method takes a CSV representation of Vehicle Position records, converts it to a Parquet file on the fly and runs it throughprocess_gtfs_rt_filesto populate GTFS-RT RDS tables.After Processing, a query selects records from the RDS and compares them against a CSV results file to confirm that there have been no fundamental changes to the Performance Manager processing pipelines.
The input CSV file consists of mostly whole route trips, 3 in each direction for each MBTA Rail line.
This PR required the updating of GTFS and GTFS-RT test files in the
SPRINGBOARDtest_filesfolder of the repository to match that date of records from the flat file (May 8th 2023). In an effort to reduce the repository size, all non rail data has also been stripped from theSPRINGBOARDparquet files ofRT_TRIP_UPDATESandRT_VEHICLE_POSITIONS.This Branch was developed with a commit from prior to the inclusion of the PR that removed hash columns from the application. This was done to provide a check against the validity of the changes introduced by that PR.
Asana Task: https://app.asana.com/0/1204931901750655/1205084207879142