Update GTFS_RT ingestion pipeline for older files #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GTFS_RT files generated from Sept 2019 through March 2020 have a different naming scheme and different extensions. Both changes break the way our ingestion pipeline currently works. Patch these issues and update our tests to check them. * `ConfigType.from_filename` updated to handle new trip updates and vehicle position file names. (NOTE, I put all the other files from these dates through this function, and they were a ok. * `GtfsRtConverter.pyarrow_from_gz` tries to choose the compression algo from the file extension, but tries to force a gz algo if that fails.
mzappitello
commented
Jul 31, 2023
| @@ -48,18 +48,29 @@ def from_filename(cls, filename: str) -> ConfigType: | |||
| # disable too many returns error message | |||
| if "mbta.com_realtime_Alerts_enhanced" in filename: | |||
| return cls.RT_ALERTS | |||
|
|
|||
There was a problem hiding this comment.
i added spacing between blocks to make it read a little easier.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GTFS_RT files generated from Sept 2019 through March 2020 have a different naming scheme and different extensions. Both changes break the way our ingestion pipeline currently works. Patch these issues and update our tests to check them.
ConfigType.from_filenameupdated to handle new trip updates and vehicle position file names. (NOTE, I put all the other files from these dates through this function, and they were a ok.GtfsRtConverter.pyarrow_from_gztries to choose the compression algo from the file extension, but tries to force a gz algo if that fails.Asana Task: https://app.asana.com/0/1204931901750655/1205130684703916/f