Change rail-pm task count from github action #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We sometimes want to change the task count for the rail performance manager as well. Add an input that lets us specify the application we're adjusting the task count on. Use the choice type to create drop-downs on the github page.
mzappitello
commented
Oct 26, 2023
There was a problem hiding this comment.
moved this since its not just ingestion.
mzappitello
commented
Oct 26, 2023
Comment on lines
+6
to
+11
| environment: | ||
| type: choice | ||
| description: What environment to change the task count for | ||
| options: | ||
| - dev | ||
| - staging |
There was a problem hiding this comment.
use a choice rather than having us enter the string. it should create a drop down on the github action ui.
mzappitello
commented
Oct 26, 2023
Comment on lines
+15
to
+20
| application_name: | ||
| type: choice | ||
| description: What application to adjust the task count for | ||
| options: | ||
| - ingestion | ||
| - rail-performance-manager |
There was a problem hiding this comment.
let us select what application we're adjusting the task count of.
mzappitello
commented
Oct 26, 2023
Comment on lines
+24
to
+25
| if: | | ||
| ( github.event.inputs.new_count == 0 || github.event.inputs.new_count == 1) |
There was a problem hiding this comment.
choice only seems to work with ints (at least my linter yelled at me) so i left these as a manual entry. keeping this if gate to prevent us from setting the task count to 11 or something.
mzappitello
commented
Oct 26, 2023
|
|
||
| steps: | ||
| - name: run command | ||
| run: aws ecs update-service --cluster lamp --service lamp-${{ github.event.inputs.application_name }}-${{ github.event.inputs.environment }} --desired-count ${{ github.event.inputs.new_count }} |
There was a problem hiding this comment.
added the application name to the update service call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We sometimes want to change the task count for the rail performance manager as well. Add an input that lets us specify the application we're adjusting the task count on.
Use the choice type to create drop-downs on the github page.