FIX: More bugs in Manual Deploy Workflow #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Inputs need to be passed in from the workflow dispatch to the base workflow as booleans, so use a fromJson function to flip them. * Rename the env-name input to environment so that it matches with the workflow dispatch name. * Pass the environment string, not the name of the variable. * Add prod to list of environments we can change the task count for.
mzappitello
commented
Nov 15, 2023
| @@ -9,6 +9,7 @@ on: | |||
| options: | |||
| - dev | |||
| - staging | |||
| - prod | |||
There was a problem hiding this comment.
we can change the task count for prod now.
mzappitello
commented
Nov 15, 2023
| env-name: | ||
| environment: |
There was a problem hiding this comment.
rename this input, with cascading changes in the deploy workflows that call deploy-base.yaml
mzappitello
commented
Nov 15, 2023
| deploy-tableau-publisher: github.envent.inputs.deploy-tableau-publisher | ||
| # pass the inputs from the workflow dispatch through to the deploy base. the booleans are | ||
| # converted to strings, so flip them back using fromJson function | ||
| environment: ${{ github.event.inputs.environment }} |
There was a problem hiding this comment.
i was passing the string of the variable name before 😵💫
mzappitello
commented
Nov 15, 2023
Comment on lines
+35
to
+37
| deploy-ingestion: ${{ fromJson(github.event.inputs.deploy-ingestion) }} | ||
| deploy-rail-pm: ${{ fromJson(github.event.inputs.deploy-rail-pm) }} | ||
| deploy-tableau-publisher: ${{ fromJson(github.event.inputs.deploy-tableau-publisher) }} |
There was a problem hiding this comment.
using fromJson converts these from strings back to bools.
There was a problem hiding this comment.
would you want the fromJson on the inside or the outside of ${{..}} here?
There was a problem hiding this comment.
expressions go inside.
i still find all of the syntax rules a bit hard to follow, but i'm sure they stem from some weird backend interpreter they have to use.
rymarczy
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inputs need to be passed in from the workflow dispatch to the base workflow as booleans, so use a fromJson function to flip them.
Rename the env-name input to environment so that it matches with the workflow dispatch name.
Pass the environment string, not the name of the variable.
Add prod to list of environments we can change the task count for.