Fix rds writer process and with more typing #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rymarczy
reviewed
Jan 5, 2024
rymarczy
reviewed
Jan 5, 2024
mzappitello
force-pushed
the
add_typing_to_queue
branch
from
2414ea6
to
d3ae448
Compare
The RDS writer process waits for items to be put on a metadata queue, pops them off, and then writes that file to the metadata. In the past, the queue was typed with any, as it was being populated with an obscure pyarrow object we couldn't deduce properly. With the recent changes to how we write parquet files, these changed to strings. This caused the process to fail since it was attempting to pull a `path` attribute out a string, causing an uncaught exception. I've updated the process to expect a string from the queue and put in typing hints that should prevent an error like this in the future.
mzappitello
force-pushed
the
add_typing_to_queue
branch
from
d3ae448
to
ade6265
Compare
rymarczy
approved these changes
Jan 5, 2024
There was a problem hiding this comment.
LGTM
I turned off ingestion on staging and updated the metadatalog RDS table with all of the parquet paths that were written since the last manual update I did.
Should be good to deploy and kick everything back on. On PROD, I can reconcile the parquet file and metadatalog table diffs later today and write up an SQL query for the infra team to run against the PROD rds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RDS writer process waits for items to be put on a metadata queue, pops them off, and then writes that file to the metadata. In the past, the queue was typed with any, as it was being populated with an obscure pyarrow object we couldn't deduce properly.
With the recent changes to how we write parquet files, these changed to strings. This caused the process to fail since it was attempting to pull a
pathattribute out a string, causing an uncaught exception.I've updated the process to expect a string from the queue and put in typing hints that should prevent an error like this in the future.
Asana Task: https://app.asana.com/0/1205827492903547/1206288301107382/f