Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Run Task from Github Action #444

Merged
merged 2 commits into from
Oct 1, 2024
Merged

FEAT: Run Task from Github Action #444

merged 2 commits into from
Oct 1, 2024

Conversation

rymarczy
Copy link
Collaborator

This change makes it possible to start an ad-hoc ECS Service task via github action.

.github/actions/run_task/run_task.sh does the bulk of the work. It should be able to be generalized to start any AWS ECS Service Task.

This changes requires additional IAM permissions for the github action role that are found in this devops PR: https://github.com/mbta/devops/pull/2192.

Evidence of script success: https://github.com/mbta/lamp/actions/runs/11069324714

Asana Task: https://app.asana.com/0/1205827492903547/1207556073650893

Copy link

Coverage of commit c8ac31f

Summary coverage rate:
  lines......: 75.6% (2466 of 3260 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

Copy link

@arkadyan arkadyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

environment: ${{ github.event.inputs.environment }}
deploy-ad-hoc: true
secrets: inherit
# deploy:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (non-blocking): Is it worth just deleting this section outright?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, forgot to un-comment this. I just did this to speed up de-bug iteration on the run_task.sh script

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh that's a good trick.

Copy link

Coverage of commit 815bf45

Summary coverage rate:
  lines......: 75.9% (2476 of 3263 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

@rymarczy rymarczy merged commit 9d37551 into main Oct 1, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants