fix: remove search feature flag

iosApp/iosApp/ContentView.swift

@@ -103,7 +103,7 @@
             ZStack(alignment: .top) {
                 mapWithSheets
                 VStack(alignment: .trailing, spacing: 0) {
-                    if contentVM.searchEnabled, nearbyVM.navigationStack.lastSafe() == .nearby {
+                    if nearbyVM.navigationStack.lastSafe() == .nearby {
                         SearchOverlay(searchObserver: searchObserver, nearbyVM: nearbyVM, searchVM: searchVM)
                     }
                     if !searchObserver.isSearching, !viewportProvider.viewport.isFollowing,
@@ -114,9 +114,6 @@
             }
         }
         .onAppear {
-            Task {
-                await contentVM.loadSettings()
-            }
             Task {
                 await contentVM.loadConfig()
             }
@@ -155,7 +152,7 @@
 
     @ViewBuilder var mapWithSheets: some View {
         let nav = $nearbyVM.navigationStack.wrappedValue.lastSafe()
         let sheetItem: Binding<NearbySheetItem?> = .constant(
             searchObserver.isSearching && nav == .nearby ? .none : nav.sheetItemIdentifiable()
         )
         let sheetItemId: String? = nearbyVM.navigationStack.lastSafe().sheetItemIdentifiable()?.id

iosApp/iosApp/ContentViewModel.swift

@@ -12,33 +12,19 @@ import shared
 
 class ContentViewModel: ObservableObject {
     @Published var configResponse: ApiResult<ConfigResponse>?
-    @Published var searchEnabled: Bool
-    private var settings: Set<Setting> = []
 
     var configUseCase: ConfigUseCase
-    var settingsRepo: ISettingsRepository
 
     init(configUseCase: ConfigUseCase = UsecaseDI().configUsecase,
-         configResponse: ApiResult<ConfigResponse>? = nil,
-         searchEnabled: Bool = false,
-         settingsRepo: ISettingsRepository = RepositoryDI().settings) {
+         configResponse: ApiResult<ConfigResponse>? = nil) {
         self.configUseCase = configUseCase
         self.configResponse = configResponse
-        self.searchEnabled = searchEnabled
-        self.settingsRepo = settingsRepo
     }
 
     func configureMapboxToken(token: String) {
         MapboxOptions.accessToken = token
     }
 
-    @MainActor func loadSettings() async {
-        do {
-            let settings = try await settingsRepo.getSettings()
-            searchEnabled = settings.first(where: { $0.key == .search })?.isOn ?? false
-        } catch {}
-    }
-
     @MainActor func loadConfig() async {
         do {
             configResponse = try await configUseCase.getConfig()

iosApp/iosApp/Pages/Settings/Setting+Convenience.swift

@@ -16,8 +16,6 @@ extension Setting: Identifiable {
 
     var name: String {
         switch key {
-        case .search:
-            "Search"
         case .searchRouteResults:
             "Search - Route Results"
         case .map:
@@ -27,8 +25,6 @@ extension Setting: Identifiable {
 
     var icon: String {
         switch key {
-        case .search:
-            "magnifyingglass"
         case .searchRouteResults:
             "point.topleft.down.to.point.bottomright.curvepath.fill"
         case .map:
@@ -38,8 +34,6 @@ extension Setting: Identifiable {
 
     var category: SettingsSection.Category {
         switch key {
-        case .search:
-            .featureFlags
         case .searchRouteResults:
             .featureFlags
         case .map:

iosApp/iosAppTests/Pages/Settings/SettingsPageTests.swift

@@ -20,13 +20,13 @@ final class SettingsPageTests: XCTestCase {
 
         init(
             mapDebug: Bool,
-            searchFeatureFlag: Bool,
+            searchRouteResults: Bool,
             onGet: (() -> Void)? = nil,
             onSet: ((Set<Setting>) -> Void)? = nil
         ) {
             settings = [
                 Setting(key: .map, isOn: mapDebug),
-                Setting(key: .search, isOn: searchFeatureFlag),
+                Setting(key: .searchRouteResults, isOn: searchRouteResults),
             ]
             self.onGet = onGet
             self.onSet = onSet
@@ -48,7 +48,7 @@ final class SettingsPageTests: XCTestCase {
 
         let settingsRepository = FakeSettingsRepository(
             mapDebug: true,
-            searchFeatureFlag: false,
+            searchRouteResults: false,
             onGet: {
                 loadedPublisher.send(())
             }
@@ -71,7 +71,7 @@ final class SettingsPageTests: XCTestCase {
 
         let settingsRepository = FakeSettingsRepository(
             mapDebug: false,
-            searchFeatureFlag: false,
+            searchRouteResults: false,
             onGet: {
                 loadedPublisher.send(())
             },

iosApp/iosAppTests/Views/ContentViewModelTests.swift

@@ -24,11 +24,4 @@ final class ContentViewModelTests: XCTestCase {
         await contentVM.loadConfig()
         XCTAssertEqual(contentVM.configResponse, expectedResult)
     }
-
-    func testLoadSettingsSetsSettings() async {
-        let expectedResult: Set<Setting> = [.init(key: .search, isOn: true)]
-        let contentVM = ContentViewModel(settingsRepo: MockSettingsRepository(settings: expectedResult))
-        await contentVM.loadSettings()
-        XCTAssertTrue(contentVM.searchEnabled)
-    }
 }

shared/src/commonMain/kotlin/com/mbta/tid/mbta_app/repositories/SettingsRepository.kt

@@ -36,7 +36,6 @@ class SettingsRepository : ISettingsRepository, KoinComponent {
 
 enum class Settings(val dataStoreKey: Preferences.Key<Boolean>) {
     Map(booleanPreferencesKey("map_debug")),
-    Search(booleanPreferencesKey("search_featureFlag")),
     SearchRouteResults(booleanPreferencesKey("searchRouteResults_featureFlag")),
 }