Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Store.Predictions): Add log when record removed for debugging #216

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

KaylaBrady
Copy link
Collaborator

Summary

Ticket: In support of Predictions crash due to missing trip

What is this PR for?

One possible reason that clients are experiencing missing trips is that the trip could be removed from the ETS store prematurely. By logging when trips & predictions are removed from the store, we can better understand if trips are removed before their corresponding predictions in the backend or if this is a frontend issue.

@KaylaBrady KaylaBrady requested a review from a team as a code owner October 11, 2024 17:39
@KaylaBrady KaylaBrady requested review from EmmaSimon and removed request for a team October 11, 2024 17:39
Copy link

Coverage of commit eb11d05

Summary coverage rate:
  lines......: 79.7% (1364 of 1711 lines)
  functions..: 69.6% (569 of 817 functions)
  branches...: no data found

Files changed coverage rate:
                                                                         |Lines       |Functions  |Branches    
  Filename                                                               |Rate     Num|Rate    Num|Rate     Num
  =============================================================================================================
  lib/mbta_v3_api/store/predictions.ex                                   |98.4%     62| 100%    13|    -      0

Download coverage report

@KaylaBrady KaylaBrady merged commit 22a2bd2 into main Oct 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants