Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add digital payments flavour #331

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

eljhkrr
Copy link
Member

@eljhkrr eljhkrr commented Oct 4, 2023

No description provided.

@eljhkrr eljhkrr requested review from jkuester and m5r and removed request for latin-panda October 4, 2023 19:38
Copy link
Contributor

@jkuester jkuester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! The only question I have is about the brand name.

I don't have a lot of context for this particular app, but I see from the strings.xml that is it for Zanzibar. In that case, it feels like digital_payments is a bit vague. Unless we are planning to have this app reused by other deployments, I would have expected a brand name more like moh_zanzibar_payments or something.... (But, like I said, I don't have a lot of context here, so if the branding has already been discussed, then I do not intend to re-open the conversation here!)

Also, this is minor, but do we have any icon to supply for this APK?

@eljhkrr
Copy link
Member Author

eljhkrr commented Oct 26, 2023

Thanks for the feedback. We don't have any icons yet for the project and the naming was based off the main instance name for the pilot. Once it goes live the preferred name would be moh_zanzibar_payments.

Copy link

sonarcloud bot commented Mar 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@m5r m5r removed their request for review April 24, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants