Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(#8704): clean up and organize /reports e2e test folder #9280

Merged
merged 41 commits into from
Sep 9, 2024
Merged

chore(#8704): clean up and organize /reports e2e test folder #9280

merged 41 commits into from
Sep 9, 2024

Conversation

tatilepizs
Copy link
Contributor

@tatilepizs tatilepizs commented Jul 23, 2024 •
edited
Loading

Description

Clean and organize the e2e tests that are inside the reports folder.

  • breadcrumbs.wdio-spec.js
  • bulk-delete.wdio-spec.js
  • date-filter.wdio-spec.js
  • delete.wdio-spec.js
  • export.wdio-spec.js
  • generate-short-codes.wdio-spec.js
  • infinite-scrolling.wdio-spec.js
  • reports-subject.wdio-spec.js
  • search-reports.wdio-spec.js
  • sidebar-filter.wdio-spec.js
  • sms-messages.wdio-spec.js
  • test-app_settings.js

#8704

Code review checklist

  • Readable: Concise, well named, follows the style guide, documented if necessary.
  • Documented: Configuration and user documentation on cht-docs
  • Tested: Unit and/or e2e where appropriate
  • Internationalised: All user facing text
  • Backwards compatible: Works with existing data and configuration or includes a migration. Any breaking changes documented in the release notes.

Compose URLs

If Build CI hasn't passed, these may 404:

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

tatilepizs and others added 30 commits July 22, 2024 14:56
@tatilepizs
clean and organize breadcrumbs.wdio-spec.js e2e test
dc7cc6a
@tatilepizs
Merge branch 'master' of https://github.com/medic/cht-core into 8704-…
43708d5 
…clean-up-and-organize-reports-folder
@tatilepizs
clean and organize bulk-delete.wdio-spec.js e2e test
cdb689c
@tatilepizs
add default values to 'patient' and 'submitter'
94b0aa5
@tatilepizs
clean and organize date-filter.wdio-spec.js e2e test
55cf51f
@tatilepizs
clean and organize delete.wdio-spec.js e2e test
88975e6
@tatilepizs
clean and organize export.wdio-spec.js e2e test
e5af4e6
@tatilepizs
clean and organize generate-short-codes.wdio-spec.js e2e test
8926d49
@latin-panda
chore(#8181): remove old action bar (#9297)
a9ba230
@latin-panda
Merge branch 'master' of https://github.com/medic/cht-core into 8181-…
0420e98 
…remove-old-design
@tatilepizs
clean and organize infinite-scrolling.wdio-spec.js e2e test
fdac6af
@tatilepizs
update from "docker-compose" to "docker compose"
b53f636
@tatilepizs
Merge branch 'master' of https://github.com/medic/cht-core into 8704-…
e5f1948 
…clean-up-and-organize-reports-folder
@tatilepizs
typo
fc34e81
@tatilepizs
clean up and organize reports-subject.wdio-spec.js e2e test
7d2b588
@tatilepizs
clean up and organize search-reports.wdio-spec.js e2e test
4aafc66
@tatilepizs
clean up and organize sidebar-filter.wdio-spec.js e2e test
3aa581a
@tatilepizs
Merge branch 'master' of https://github.com/medic/cht-core into 8704-…
8e96ef2 
…clean-up-and-organize-reports-folder
@latin-panda
feat(#8181): remove old search and filter (#9326)
4779672
@latin-panda
feat(#9327): extend content to full width (#9356)
b19fdec
@Benmuiruri @tatilepizs
chore(#9327): add feature flag and hide old navigation (#9330)
fd9bc0a 
Co-authored-by: Tatiana Lépiz Soto <94494491+tatilepizs@users.noreply.github.com>
Co-authored-by: Aniekan Eshiet <aeshiet@Aniekans-Medic-MacBook-Pro.local>
@kapelo @Benmuiruri @tatilepizs
chore: add new e2e test for old navigation on mobile (#9366)
cc1ee38 
Co-authored-by: Ben Kiarie <kiarie@medic.org>
Co-authored-by: Tatiana Lépiz Soto <94494491+tatilepizs@users.noreply.github.com>
Co-authored-by: Aniekan Eshiet <aeshiet@Aniekans-Medic-MacBook-Pro.local>
@tatilepizs
Merge branch 'master' of https://github.com/medic/cht-core into 8704-…
4c5a558 
…clean-up-and-organize-reports-folder
@tatilepizs
clean up and organize sms-messages.wdio-spec.js e2e test
e2a363f
@tatilepizs
organize reports.wdio.page.js
697ff5b
@tatilepizs
Merge branch 'master' of https://github.com/medic/cht-core into 8704-…
dad3b77 
…clean-up-and-organize-reports-folder
@tatilepizs
update broken mobile tests
384b502
@tatilepizs
update broken mobile tests - part 2
7f1d99a
@tatilepizs
updates part 1
7601c7c
@tatilepizs
Merge branch 'master' of https://github.com/medic/cht-core into 8704-…
372be8c 
…clean-up-and-organize-reports-folder
@tatilepizs tatilepizs marked this pull request as ready for review August 30, 2024 15:18
jkuester
jkuester approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@jkuester jkuester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! I appreciate the organization of the page files since it makes it a lot easier to consume the various functionality and find the selectors that I need for my test!

Just left some minor comments/suggestions, but nothing big!

tests/e2e/default-mobile/reports/bulk-delete.wdio-spec.js Show resolved Hide resolved
tests/e2e/default/reports/bulk-delete.wdio-spec.js Show resolved Hide resolved
tests/e2e/default/reports/delete.wdio-spec.js Outdated Show resolved Hide resolved
tests/e2e/default/reports/reports-subject.wdio-spec.js Outdated Show resolved Hide resolved
lorerod
lorerod requested changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@lorerod lorerod left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @tatilepizs, for the improvements! I love the selector grouping and the code cleanup when creating reports! I just left a couple of suggestions.
I'm sorry if I was repetitive about the cleanup after the test; it is important not to affect subsequent tests.
Let me know what you think.

tests/page-objects/default/reports/reports.wdio.page.js Outdated Show resolved Hide resolved
tests/page-objects/default/reports/reports.wdio.page.js Outdated Show resolved Hide resolved
tests/page-objects/default-mobile/reports/reports.wdio.page.js Show resolved Hide resolved
tests/page-objects/default-mobile/reports/reports.wdio.page.js Show resolved Hide resolved
tests/e2e/default/translations/nepali-dates-and-numbers.wdio-spec.js Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please verify if we are cleaning up after the test. If I understand correctly, this test updates the settings, and the settings do not revert afterward.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it is ok with you, we can clean up this test when we are working on the ticket #8705 😊

tests/e2e/default/reports/old-filter-by-date.wdio-spec.js Show resolved Hide resolved
tests/e2e/default/reports/generate-short-codes.wdio-spec.js Show resolved Hide resolved
tests/e2e/default/reports/export.wdio-spec.js Outdated Show resolved Hide resolved
tests/e2e/default/reports/delete.wdio-spec.js Show resolved Hide resolved
tests/e2e/default/reports/breadcrumbs.wdio-spec.js Outdated Show resolved Hide resolved
@tatilepizs
Copy link
Contributor Author

I'm sorry if I was repetitive about the cleanup after the test

Thank you Lore for reminding me to clean the test files, as you said, it is really important to do it and I always forget it.
I appreciate your comments, I will try to remember for the next time 😅

Can you please take a look again? I think that I am done with all the feedback.

lorerod
lorerod approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@lorerod lorerod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @tatilepizs! LGTM
I left some suggestions around the refactoring of select and deselect reports, but this is good to go.

tests/page-objects/default/reports/reports.wdio.page.js Outdated Show resolved Hide resolved
tests/page-objects/default/reports/reports.wdio.page.js Outdated Show resolved Hide resolved
tests/page-objects/default/reports/reports.wdio.page.js Outdated Show resolved Hide resolved
tests/page-objects/default/reports/reports.wdio.page.js Outdated Show resolved Hide resolved
tests/page-objects/default/reports/reports.wdio.page.js Outdated Show resolved Hide resolved
tests/page-objects/default/reports/reports.wdio.page.js Outdated Show resolved Hide resolved
@tatilepizs tatilepizs merged commit b113fbc into master Sep 9, 2024
44 checks passed
@tatilepizs tatilepizs deleted the 8704-clean-up-and-organize-reports-folder branch September 9, 2024 14:39
@tatilepizs tatilepizs mentioned this pull request Sep 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorerod lorerod lorerod approved these changes

@jkuester jkuester jkuester approved these changes

@kapelo kapelo Awaiting requested review from kapelo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tatilepizs @jkuester @lorerod @latin-panda @Benmuiruri @kapelo