chore(#9534): upgrade PouchDB to version 9 #9550
Conversation
latin-panda
changed the title
| @@ -234,8 +234,14 @@ describe('Db Service', () => { | |||
| }); | |||
|
|
|||
| describe('method wrapping', () => { | |||
| let testDB; | |||
| let syncTarget; | |||
|
|
|||
| beforeEach(() => { | |||
| window.PouchDB = require('pouchdb-browser').default; | |||
There was a problem hiding this comment.
All these functions from L251 (bulkGet, get, allDocs, etc) aren't located in window.PouchDB.prototype. The PouchInternal's constructor calls _setup() to add all those functions to a DB instance.
To make these tests work, we create an instance and make window.PouchDB return it, so later we stub its functions.
| @@ -6,7 +6,7 @@ const user = config.users[threadId % config.users.length]; | |||
| const rewire = require('rewire'); | |||
| const rpn = require('request-promise-native'); | |||
|
|
|||
| const PouchDB = require('pouchdb'); | |||
| const PouchDB = require('pouchdb-browser'); | |||
There was a problem hiding this comment.
To test: Does it work?
There was a problem hiding this comment.
Why not use pouchdb-core? pouchdb-browser is made specifically for the browser and packages the indexeddb adapters, which are not needed here.
| @@ -3,7 +3,7 @@ const threadId = args[0]; | |||
| const config = require('./config.json'); | |||
| const user = config.users[threadId % config.users.length]; | |||
|
|
|||
| const PouchDB = require('pouchdb'); | |||
| const PouchDB = require('pouchdb-browser'); | |||
There was a problem hiding this comment.
To test: Does it work?
| @@ -6,7 +6,7 @@ const user = config.users[threadId % config.users.length]; | |||
| const rewire = require('rewire'); | |||
| const rpn = require('request-promise-native'); | |||
|
|
|||
| const PouchDB = require('pouchdb'); | |||
| const PouchDB = require('pouchdb-browser'); | |||
There was a problem hiding this comment.
Why not use pouchdb-core? pouchdb-browser is made specifically for the browser and packages the indexeddb adapters, which are not needed here.
| @@ -3,7 +3,7 @@ const threadId = args[0]; | |||
| const config = require('./config.json'); | |||
| const user = config.users[threadId % config.users.length]; | |||
|
|
|||
| const PouchDB = require('pouchdb'); | |||
| const PouchDB = require('pouchdb-browser'); | |||
| await target.bulkDocs([{ _id: uuidv4() }]); | ||
| sinon.stub(target, 'allDocs').rejects({ status: 400, name: 'forbidden' }); | ||
| await syncTarget.bulkDocs([{ _id: uuidv4() }]); | ||
| sinon.stub(syncTarget, 'bulkGet').rejects({ status: 400, name: 'forbidden' }); |
There was a problem hiding this comment.
Hm, did the internal sync implementation change?
There was a problem hiding this comment.
I tried to check the sync implementation (node-modules) because it wasn't breaking with rejection from allDocs, but bulkGet breaks it. I need to research more
Description
WIP
#9534
Code review checklist
Compose URLs
If Build CI hasn't passed, these may 404:
License
The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.