Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added tests + multiple bug fixes + UTF-8 robustness #17

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

tilo
Copy link

@tilo tilo commented Aug 15, 2018

Looks like this gem is unmaintained 😞

If you still need to use it, you might want to consider these updates and fixes:

  • applied all the outstanding PRs of the original gem
  • fixed gemspec file and Rakefile to be modern style
  • removed unused ./test directory
  • added RSpec tests
  • converted RSpec tests to RSpec 3 syntax
  • cleaned up Ruby style
  • fixed and simplified regular expressions
  • fixed parsing so it does not break names with UTF-8 characters!
  • allowing 2nd, 3rd, 4th, Nth
  • added lots of test cases
  • fixed bugs in the parsing
  • stripping spaces from titles and suffixes
  • recognizing double middle names (might require you to do post-processing for double last names)

@tilo tilo changed the title added tests + multiple bug fixes added tests + multiple bug fixes + UTF-8 robustness Aug 15, 2018
@tilo
Copy link
Author

tilo commented Aug 15, 2018

it's important to use \p{Word} instead of [A-Za-z] or \w+, so UTF-8 characters are included!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant