Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send configuration fo mesonbuild to language server, if it changed #164

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

JCWasmx86
Copy link
Contributor

@JCWasmx86 JCWasmx86 commented Oct 23, 2023

Configuration format is like this in your .settings.json

{
    "mesonbuild.Swift-MesonLSP": {
        "others": {
            "ignoreDiagnosticsFromSubprojects": true,
        },
        "linting": {
            "disableNameLinting": true,
            "disableCompilerIdLinting": true,
        }
    }
}

Testing:

Your diagnostics will look like this:
image

Merge the config listed above with your .settings.json.

Only this error will be left:
image

(A bug on my side, as my heuristics will never be able to guess the sophisticated subdir calculation for hse-python, but that's offtopic here)

Only thing missing here is the auto-completion/diagnostics in the settings.json file.

@JCWasmx86
Copy link
Contributor Author

Not sure, if we need a changelog item for that, as it is only a little user-visible.

src/lsp/index.ts Outdated Show resolved Hide resolved
src/lsp/index.ts Outdated Show resolved Hide resolved
@tristan957
Copy link
Contributor

Let's just add a changelog entry.

@tristan957
Copy link
Contributor

It is funny that you are testing with HSE. Fun project to work on. Too bad Micron laid us all off :(

@JCWasmx86
Copy link
Contributor Author

Not sure how useful the changelog item is. I would quickly write a doc for that on my git repo with all the options. That's the best way I can keep it in sync I think

@tristan957
Copy link
Contributor

That is fine with me.

@tristan957 tristan957 merged commit d888756 into mesonbuild:main Oct 23, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants