Fix random file being chosen to create project #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xclaesse
reviewed
Nov 16, 2023
|
|
||
| export async function rootMesonFiles(): Promise<vscode.Uri[]> { | ||
| const allFiles = (await vscode.workspace.findFiles("**/meson.build")).sort( | ||
| (a, b) => a.fsPath.length - b.fsPath.length, |
There was a problem hiding this comment.
That's the path lenght in chars? Won't it make a/b/meson.build before long_dir_name/meson.build?
There was a problem hiding this comment.
Hmm you're right. I think I need to sort by file path components
There was a problem hiding this comment.
If I understand the code correctly, I don't think this would be a problem. The path-length check should be sufficient, since there's no scenario in which you would have found a parent-level meson.build after processing a subdirectory of said parent.
|
In python I would do: import os
for root, dirs, files in os.walk("."):
if "meson.build" in files:
print(f"Root at {root}")
# Do not look into subdirs if we found a meson.build file
dirs.clear() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.