Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass environment to the testing debugger #241

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Conversation

cskeogh
Copy link
Contributor

@cskeogh cskeogh commented Jun 17, 2024

The C++ debugger requires "environment" key in the format
[ { "name": "config", "value": "Debug" } ]
https://code.visualstudio.com/docs/cpp/launch-json-reference

Note: I think Javascript uses 'env'. Python uses 'env'. Annoying. This patch doesn't account for Javascript or Python. Not sure if that is a problem.

Fixes #240

@tristan957
Copy link
Contributor

Could you make a note in the source code that this would only work for the C/C++ debugger from the C/C++ extension (presumably that's what you mean?)

@tristan957
Copy link
Contributor

Actually, maybe it would be better to special case it in a if statement?

@cskeogh
Copy link
Contributor Author

cskeogh commented Jun 19, 2024

Actually, maybe it would be better to special case it in a if statement?

I added the if statement 👍

@tristan957
Copy link
Contributor

Can you squash the commits? I'll make a new release today.

The C++ debugger requires "environment" key.
https://code.visualstudio.com/docs/cpp/launch-json-reference
Only set the debugger "environment" key if debugType is 'cppdbg'
(running under ms-vscode.cpptools), otherwise "env" key.

Fixes mesonbuild#240
@cskeogh
Copy link
Contributor Author

cskeogh commented Jun 22, 2024

Can you squash the commits? I'll make a new release today.

Squashed 👍

@tristan957 tristan957 added this pull request to the merge queue Jun 24, 2024
Merged via the queue into mesonbuild:main with commit 9fd1b31 Jun 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Environment not working for debug test framework
2 participants