Skip to content

Commit

Permalink
fix: not skipping authz for kube dashboard (2.5) (#1486)
Browse files Browse the repository at this point in the history
fix: not skipping authz for kube dashboard (#1462)

* fix: should not skip authz for any path

see TFA Code about this config option:

https://github.com/mesosphere/

traefik-forward-auth/blob/master/internal/handlers/server.go#L497-L504

had to break the URL to 2 lines thanks to pre-commit ;)

* fix: bring back kiali skip authz

(cherry picked from commit 78c47b3)

Co-authored-by: Weiyanli Chen(York) <6115189+cwyl02@users.noreply.github.com>
  • Loading branch information
github-actions[bot] and cwyl02 authored Aug 15, 2023
1 parent d20329b commit a47459c
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 0 additions & 2 deletions services/traefik-forward-auth-mgmt/0.3.9/defaults/cm.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,6 @@ data:
enableRBAC: true
enableImpersonation: true
rbacPassThroughPaths:
- "/dkp/kubernetes/"
- "/dkp/kubernetes/*"
- "/dkp/kiali/"
- "/dkp/kiali/*"
ingress:
Expand Down
4 changes: 3 additions & 1 deletion services/traefik-forward-auth/0.3.8/defaults/cm.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,9 @@ data:
whitelist: []
enableRBAC: true
enableImpersonation: true
rbacPassThroughPaths: ["/dkp/kubernetes/", "/dkp/kubernetes/*"]
rbacPassThroughPaths:
- "/dkp/kiali/"
- "/dkp/kiali/*"
extraConfig: |
cookie-name = _forward_auth_kommander
csrf-cookie-name = _forward_auth_csrf_kommander
Expand Down

0 comments on commit a47459c

Please sign in to comment.