Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Validate PR title length instead of commit #1433

Merged
merged 2 commits into from
Jul 27, 2023

Conversation

gracedo
Copy link
Contributor

@gracedo gracedo commented Jul 26, 2023

What problem does this PR solve?:
Add gitlint rule to ignore commit titles that are too long; since PR titles are used in squash commits, we don't gain anything by limiting the commit messages. Instead, validate that PR titles are not too long.

example of failed run when I updated title to be too long: https://github.com/mesosphere/kommander-applications/actions/runs/5674273398/job/15377493428?pr=1433

Error: Pull Request title "ci: Validate PR title length instead of commit and this is going to be super long now you should fail" is greater than max length specified - 72

Which issue(s) does this PR fix?:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Checklist

  • If the PR adds a version bump, ensure there is no breaking change in Licensing model (or NA).
  • If a chart is changed or app configuration is significantly changed, the chart version is correctly incremented (so that apps are not automatically upgraded from a previous version of DKP).

@gracedo gracedo self-assigned this Jul 26, 2023
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 26, 2023
@d2iq-mergebot
Copy link
Contributor

This repo has @d2iq-mergebot integration. You can perform the following commands by submitting a comment. Submit a comment with content "@d2iq-mergebot help" to view more detailed help text and examples. Be sure the have a look at the mergebot documentation, too.For help using mergebot, please refer to the README file here: https://github.com/mesosphere/mergebot/blob/main/README.md
Enabled Mergebot commands:
@d2iq-mergebot test all
@d2iq-mergebot test
@d2iq-mergebot override-status
@d2iq-mergebot help
@d2iq-mergebot backport

@gracedo gracedo changed the title ci: Validate PR title length instead of commit ci: Validate PR title length instead of commit and this is going to be super long now you should fail Jul 26, 2023
@coveralls
Copy link

coveralls commented Jul 26, 2023

Pull Request Test Coverage Report for Build 5683851359

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.532%

Totals Coverage Status
Change from base Build 5671799732: 0.0%
Covered Lines: 136
Relevant Lines: 171

💛 - Coveralls

@gracedo gracedo changed the title ci: Validate PR title length instead of commit and this is going to be super long now you should fail ci: Validate PR title length instead of commit Jul 26, 2023
@gracedo gracedo force-pushed the gracedo/gitlint_ignore_title_len branch from ec3597b to 18f41b5 Compare July 26, 2023 22:23
@gracedo gracedo marked this pull request as ready for review July 26, 2023 22:38
@gracedo gracedo force-pushed the gracedo/gitlint_ignore_title_len branch from 18f41b5 to 6dd05e4 Compare July 27, 2023 17:14
@gracedo gracedo requested a review from a team July 27, 2023 17:22
@github-actions github-actions bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 27, 2023
@gracedo gracedo merged commit 983334a into main Jul 27, 2023
9 checks passed
@gracedo gracedo deleted the gracedo/gitlint_ignore_title_len branch July 27, 2023 18:39
gracedo added a commit that referenced this pull request Aug 16, 2023
* ci(pre-commit): Ignore commit title length in gitlint config, validate in PR title instead

* fix(gha): Remove invalid pull_request_target action for pr linter
gracedo added a commit that referenced this pull request Aug 16, 2023
* ci(pre-commit): Ignore commit title length in gitlint config, validate in PR title instead

* fix(gha): Remove invalid pull_request_target action for pr linter
gracedo added a commit that referenced this pull request Aug 16, 2023
* ci(pre-commit): Ignore commit title length in gitlint config, validate in PR title instead

* fix(gha): Remove invalid pull_request_target action for pr linter
gracedo added a commit that referenced this pull request Aug 17, 2023
…#1492)

* fix(kps): Remove duplicate apiserver and unused keepalived scrapeconfig (#1483)

* fix(kps): Remove duplicate apiserver scrapeconfig

It looks like the KPS chart already defines a servicemonitor which
scrapes the apiserver metrics. Our additional scrapeconfig definition is
resulting in scraping the same apiserver targets and generating
duplicate metrics. We can remove our scrape config and rely on the chart
created servicemonitor.

* fix(kps): Remove unnecessary keepalived scrape target

(cherry picked from commit 90b170c)

* ci: Validate PR title length instead of commit (#1433)

* ci(pre-commit): Ignore commit title length in gitlint config, validate in PR title instead

* fix(gha): Remove invalid pull_request_target action for pr linter

* ci(gitlint): Increase body-max-line-length

---------

Co-authored-by: Grace Do <xgrace@gmail.com>
gracedo added a commit that referenced this pull request Aug 17, 2023
…#1491)

* fix(kps): Remove duplicate apiserver and unused keepalived scrapeconfig (#1483)

* fix(kps): Remove duplicate apiserver scrapeconfig

It looks like the KPS chart already defines a servicemonitor which
scrapes the apiserver metrics. Our additional scrapeconfig definition is
resulting in scraping the same apiserver targets and generating
duplicate metrics. We can remove our scrape config and rely on the chart
created servicemonitor.

* fix(kps): Remove unnecessary keepalived scrape target

(cherry picked from commit 90b170c)

* ci: Validate PR title length instead of commit (#1433)

* ci(pre-commit): Ignore commit title length in gitlint config, validate in PR title instead

* fix(gha): Remove invalid pull_request_target action for pr linter

* ci(gitlint): Increase body-max-line-length

---------

Co-authored-by: Grace Do <xgrace@gmail.com>
gracedo added a commit that referenced this pull request Aug 18, 2023
…#1493)

* fix(kps): Remove duplicate apiserver and unused keepalived scrapeconfig (#1483)

* fix(kps): Remove duplicate apiserver scrapeconfig

It looks like the KPS chart already defines a servicemonitor which
scrapes the apiserver metrics. Our additional scrapeconfig definition is
resulting in scraping the same apiserver targets and generating
duplicate metrics. We can remove our scrape config and rely on the chart
created servicemonitor.

* fix(kps): Remove unnecessary keepalived scrape target

(cherry picked from commit 90b170c)

* ci: Validate PR title length instead of commit (#1433)

* ci(pre-commit): Ignore commit title length in gitlint config, validate in PR title instead

* fix(gha): Remove invalid pull_request_target action for pr linter

* ci(gitlint): Increase body-max-line-length

---------

Co-authored-by: Grace Do <xgrace@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-review size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants