ci: Validate PR title length instead of commit #1433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
size/S
|
This repo has @d2iq-mergebot integration. You can perform the following commands by submitting a comment. Submit a comment with content "@d2iq-mergebot help" to view more detailed help text and examples. Be sure the have a look at the mergebot documentation, too.For help using mergebot, please refer to the README file here: https://github.com/mesosphere/mergebot/blob/main/README.md |
gracedo
changed the title
Pull Request Test Coverage Report for Build 5683851359
💛 - Coveralls |
gracedo
changed the title
gracedo
force-pushed
the
gracedo/gitlint_ignore_title_len
branch
from
ec3597b
to
18f41b5
Compare
…e in PR title instead
gracedo
force-pushed
the
gracedo/gitlint_ignore_title_len
branch
from
18f41b5
to
6dd05e4
Compare
github-actions
bot
added
size/XS
bcm820
approved these changes
Jul 27, 2023
cbuto
approved these changes
Jul 27, 2023
gracedo
added a commit
that referenced
this pull request
Aug 16, 2023
* ci(pre-commit): Ignore commit title length in gitlint config, validate in PR title instead * fix(gha): Remove invalid pull_request_target action for pr linter
gracedo
added a commit
that referenced
this pull request
Aug 16, 2023
* ci(pre-commit): Ignore commit title length in gitlint config, validate in PR title instead * fix(gha): Remove invalid pull_request_target action for pr linter
gracedo
added a commit
that referenced
this pull request
Aug 16, 2023
* ci(pre-commit): Ignore commit title length in gitlint config, validate in PR title instead * fix(gha): Remove invalid pull_request_target action for pr linter
gracedo
added a commit
that referenced
this pull request
Aug 17, 2023
…#1492) * fix(kps): Remove duplicate apiserver and unused keepalived scrapeconfig (#1483) * fix(kps): Remove duplicate apiserver scrapeconfig It looks like the KPS chart already defines a servicemonitor which scrapes the apiserver metrics. Our additional scrapeconfig definition is resulting in scraping the same apiserver targets and generating duplicate metrics. We can remove our scrape config and rely on the chart created servicemonitor. * fix(kps): Remove unnecessary keepalived scrape target (cherry picked from commit 90b170c) * ci: Validate PR title length instead of commit (#1433) * ci(pre-commit): Ignore commit title length in gitlint config, validate in PR title instead * fix(gha): Remove invalid pull_request_target action for pr linter * ci(gitlint): Increase body-max-line-length --------- Co-authored-by: Grace Do <xgrace@gmail.com>
gracedo
added a commit
that referenced
this pull request
Aug 17, 2023
…#1491) * fix(kps): Remove duplicate apiserver and unused keepalived scrapeconfig (#1483) * fix(kps): Remove duplicate apiserver scrapeconfig It looks like the KPS chart already defines a servicemonitor which scrapes the apiserver metrics. Our additional scrapeconfig definition is resulting in scraping the same apiserver targets and generating duplicate metrics. We can remove our scrape config and rely on the chart created servicemonitor. * fix(kps): Remove unnecessary keepalived scrape target (cherry picked from commit 90b170c) * ci: Validate PR title length instead of commit (#1433) * ci(pre-commit): Ignore commit title length in gitlint config, validate in PR title instead * fix(gha): Remove invalid pull_request_target action for pr linter * ci(gitlint): Increase body-max-line-length --------- Co-authored-by: Grace Do <xgrace@gmail.com>
gracedo
added a commit
that referenced
this pull request
Aug 18, 2023
…#1493) * fix(kps): Remove duplicate apiserver and unused keepalived scrapeconfig (#1483) * fix(kps): Remove duplicate apiserver scrapeconfig It looks like the KPS chart already defines a servicemonitor which scrapes the apiserver metrics. Our additional scrapeconfig definition is resulting in scraping the same apiserver targets and generating duplicate metrics. We can remove our scrape config and rely on the chart created servicemonitor. * fix(kps): Remove unnecessary keepalived scrape target (cherry picked from commit 90b170c) * ci: Validate PR title length instead of commit (#1433) * ci(pre-commit): Ignore commit title length in gitlint config, validate in PR title instead * fix(gha): Remove invalid pull_request_target action for pr linter * ci(gitlint): Increase body-max-line-length --------- Co-authored-by: Grace Do <xgrace@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?:
Add gitlint rule to ignore commit titles that are too long; since PR titles are used in squash commits, we don't gain anything by limiting the commit messages. Instead, validate that PR titles are not too long.
example of failed run when I updated title to be too long: https://github.com/mesosphere/kommander-applications/actions/runs/5674273398/job/15377493428?pr=1433
Which issue(s) does this PR fix?:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Checklist