Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable PSPs explictly to avoid upgrade failures (2.6) #1440

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

gracedo
Copy link
Contributor

@gracedo gracedo commented Jul 31, 2023

  • fix: disable PSPs

  • fix(gatekeeper): Disable psps by default

PSP was removed in k8s 1.25, we should explicitly disable PSPs in our default values.


What problem does this PR solve?:
backports #1437

Which issue(s) does this PR fix?:

https://d2iq.atlassian.net/browse/D2IQ-98509

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Checklist

  • If the PR adds a version bump, ensure there is no breaking change in Licensing model (or NA).
  • If a chart is changed or app configuration is significantly changed, the chart version is correctly incremented (so that apps are not automatically upgraded from a previous version of DKP).

* fix: disable PSPs

* fix(gatekeeper): Disable psps by default

PSP was removed in k8s 1.25, we should explicitly disable PSPs in our
default values.

---------

Co-authored-by: Grace Do <xgrace@gmail.com>
@gracedo gracedo added ready-for-review ok-to-test Signals mergebot that CI checks are ready to be kicked off backport-pr This is a backport PR labels Jul 31, 2023
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 31, 2023
@d2iq-mergebot
Copy link
Contributor

This repo has @d2iq-mergebot integration. You can perform the following commands by submitting a comment. Submit a comment with content "@d2iq-mergebot help" to view more detailed help text and examples. Be sure the have a look at the mergebot documentation, too.For help using mergebot, please refer to the README file here: https://github.com/mesosphere/mergebot/blob/main/README.md
Enabled Mergebot commands:
@d2iq-mergebot test all
@d2iq-mergebot test
@d2iq-mergebot override-status
@d2iq-mergebot help
@d2iq-mergebot backport

@gracedo gracedo marked this pull request as ready for review July 31, 2023 22:50
Copy link
Contributor

@lukeogg lukeogg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gracedo gracedo merged commit a26bde1 into release-2.6 Jul 31, 2023
26 checks passed
@gracedo gracedo deleted the gracedo/release-2.6/disable-psps branch July 31, 2023 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-pr This is a backport PR ok-to-test Signals mergebot that CI checks are ready to be kicked off ready-for-review size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants