feat: Add pre-upgrade jobs to run helm-mapkubeapis (#1439) (2.5) #1454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbuto
added
ok-to-test
github-actions
bot
added
the
size/L
|
This repo has @d2iq-mergebot integration. You can perform the following commands by submitting a comment. Submit a comment with content "@d2iq-mergebot help" to view more detailed help text and examples. Be sure the have a look at the mergebot documentation, too.For help using mergebot, please refer to the README file here: https://github.com/mesosphere/mergebot/blob/main/README.md |
* feat(kubecost): Add pre-upgrade to run helm-mapkubeapi * feat(kubecost): Use kommander chart version for kubetools image tag * feat(kubecost): Use force true on pre-upgrade job * feat(logging-operator): Add pre-upgrade job to run helm-mapkubeapis * feat(gatekeeper): Add pre-upgrade job to run helm-mapkubeapis * fix(gatekeeper): update release name * fix(gatekeeper): add dependsOn in HR kustomization * feat: Update release script to update the kubetools image tag * chore: clean up todos * refactor: typo * fix: check if HR exists in pre-upgrade scripts --------- Co-authored-by: Grace Do <xgrace@gmail.com>
|
I've tested:
The CI checks here fail because of the version agnostic CLI |
cwyl02
reviewed
Aug 2, 2023
cwyl02
approved these changes
Aug 2, 2023
gracedo
reviewed
Aug 2, 2023
gracedo
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?:
Add pre-upgrade jobs to kubecost, logging-operator, and gatekeeper to run helm-mapkubeapis tool that takes care of editing the helmrelease secret to remove the podsecuritypolicy manifest which is unsupported starting in k8s 1.25.
This affects clusters that were upgraded from 2.4, in which the PSP api was still supported and these 3 charts had deployed PSPs. Since kommander applications are upgraded prior to k8s, we saw this:
The following section https://helm.sh/docs/topics/kubernetes_apis/#updating-api-versions-of-a-release-manifest tells us how to recover from this error -- including using this tool https://github.com/helm/helm-mapkubeapis to help us do it easily via a single command. We have included this plugin into the kubetools image: https://github.com/mesosphere/kommander/pull/3657 and are using this image in these newly added pre-upgrade jobs.
Which issue(s) does this PR fix?:
https://d2iq.atlassian.net/browse/D2IQ-98509
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Checklist