Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump gitea to v9.3.0 #1544

Merged
merged 4 commits into from
Sep 11, 2023
Merged

chore: bump gitea to v9.3.0 #1544

merged 4 commits into from
Sep 11, 2023

Conversation

Azhovan
Copy link
Contributor

@Azhovan Azhovan commented Sep 4, 2023 •
edited
Loading

What problem does this PR solve?:
Apply required changes to install successfully Gitea on Kommander namespace.

Which issue(s) does this PR fix?:
https://d2iq.atlassian.net/browse/D2IQ-98618

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Checklist

  • If the PR adds a version bump, ensure there is no breaking change in Licensing model (or NA).
  • If a chart is changed or app configuration is significantly changed, the chart version is correctly incremented (so that apps are not automatically upgraded from a previous version of DKP).

@Azhovan Azhovan self-assigned this Sep 4, 2023
@Azhovan Azhovan added the ok-to-test Signals mergebot that CI checks are ready to be kicked off label Sep 4, 2023
@github-actions github-actions bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. services/gitea and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 4, 2023
@Azhovan Azhovan force-pushed the jabar/bump-gitea-to-v9 branch 2 times, most recently from 4bb0c74 to f4d3ddc Compare September 4, 2023 18:54
@github-actions github-actions bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 5, 2023
@Azhovan Azhovan force-pushed the jabar/bump-gitea-to-v9 branch 6 times, most recently from 474fe9d to aacd055 Compare September 6, 2023 16:13
cbuto
cbuto reviewed Sep 6, 2023
View reviewed changes
services/gitea/9.3.0/defaults/kustomization.yaml Outdated Show resolved Hide resolved
services/gitea/9.3.0/defaults/pvc.yaml Outdated Show resolved Hide resolved
This was referenced Sep 6, 2023
Closed
Closed
@Azhovan Azhovan requested a review from cbuto September 7, 2023 07:25
@Azhovan
Copy link
Contributor Author

Azhovan commented Sep 8, 2023

@cbuto @jimmidyson @gracedo
is there any thing that should be done here?

@Azhovan Azhovan requested a review from cbuto September 11, 2023 11:29
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6147483181

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.532%
Totals Coverage Status
Change from base Build 6125268434: 0.0%
Covered Lines: 136
Relevant Lines: 171
💛 - Coveralls

cbuto
cbuto approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@cbuto cbuto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good + one more step towards HA 🎉

@Azhovan Azhovan merged commit f101d89 into main Sep 11, 2023
12 checks passed
@Azhovan Azhovan deleted the jabar/bump-gitea-to-v9 branch September 11, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tillt tillt tillt left review comments

@cbuto cbuto cbuto approved these changes

@gracedo gracedo Awaiting requested review from gracedo

@mhrabovcin mhrabovcin Awaiting requested review from mhrabovcin

@jimmidyson jimmidyson Awaiting requested review from jimmidyson

Assignees

@Azhovan Azhovan

Labels
ok-to-test Signals mergebot that CI checks are ready to be kicked off ready-for-review services/gitea size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Azhovan @coveralls @jimmidyson @tillt @cbuto